-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update records-wip.md #3353
Update records-wip.md #3353
Conversation
I have no idea what this means. #Closed Refers to: proposals/records-wip.md:92 in e67167a. [](commit_id = e67167a, deletion_comment = False) |
Record types, as defined herein, do not typically contain such a Refers to: proposals/records-wip.md:92 in e67167a. [](commit_id = e67167a, deletion_comment = False) |
I modified the phrasing to clarify that the return type of a Clone method must be the receiver type or a base type. |
Seems well-defined to me. Records may implicitly define a Clone method in a future revision of the spec, but I haven't gotten there yet. |
I think you need to identify the lookup rules and the error cases. In reply to: 612224166 [](ancestors = 612224166) Refers to: proposals/records-wip.md:95 in e67167a. [](commit_id = e67167a, deletion_comment = False) |
I'm having a hard time making sense of the overall specification with just the pieces you're revealing. I understand you're only implementing some pieces, but without the missing pieces of the spec... the things that are in the spec you're providing don't fit together. |
Yup, I'll try to clarify this a bit more. It may be better to just write this using "init-only" terminology and then note the implementation gaps in the PR. |
Added some notes about I'm not clear what you mean by comments on the lookup rules. The lookup for |
We don't have a "lookup for a property get". We just do a simple name lookup (or qualified name lookup). |
Relates to dotnet/roslyn#40726 (test plan for records)