Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update records spec with new warning #3883

Merged
merged 2 commits into from
Sep 11, 2020
Merged

Update records spec with new warning #3883

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93cc039
Update records spec with new warning
Youssef1313 Sep 11, 2020
a9fbf18
Update proposals/csharp-9.0/records.md
Youssef1313 Sep 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions proposals/csharp-9.0/records.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,9 @@ The synthesized property returns `typeof(R)` where `R` is the record type.
The record type implements `System.IEquatable<R>` and includes a synthesized strongly-typed overload of `Equals(R? other)` where `R` is the record type.
The method is `public`, and the method is `virtual` unless the record type is `sealed`.
The method can be declared explicitly. It is an error if the explicit declaration does not match the expected signature or accessibility, or the explicit declaration doesn't allow overriding it in a derived type and the record type is not `sealed`.

If either `Equals(R? other)` or `GetHashCode` are user-defined (not synthesized), but not both, a warning is produced.

```C#
public virtual bool Equals(R? other);
```
Expand Down