Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify conversion rules for CallerArgumentExpression #5438

Merged
merged 3 commits into from
Nov 17, 2021
Merged

Clarify conversion rules for CallerArgumentExpression #5438

merged 3 commits into from
Nov 17, 2021

Conversation

333fred
Copy link
Member

@333fred 333fred commented Nov 16, 2021 •
edited
Loading

@333fred 333fred requested a review from a team as a code owner November 16, 2021 21:28
@333fred 333fred mentioned this pull request Nov 16, 2021
Merged
@333fred @Youssef1313
Update proposals/csharp-10.0/caller-argument-expression.md
b026ac6 
Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
@jcouv
Copy link
Member

jcouv commented Nov 17, 2021

Do we have corresponding tests on the roslyn side?

jcouv
jcouv approved these changes Nov 17, 2021
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 3)

@333fred
Copy link
Member Author

333fred commented Nov 17, 2021

Do we have corresponding tests on the roslyn side?

Yes.

@333fred 333fred merged commit 3f10d7b into main Nov 17, 2021
@333fred 333fred deleted the callerargexpression-conversion branch November 17, 2021 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaakov-h yaakov-h yaakov-h left review comments

@Youssef1313 Youssef1313 Youssef1313 left review comments

@jcouv jcouv jcouv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@333fred @jcouv @yaakov-h @Youssef1313