Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Metadata section in params-collections.md #7850

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Update Metadata section in params-collections.md #7850

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7a63e1
Update `Metadata` section in params-collections.md
AlekseyTs Jan 16, 2024
519f117
Update proposals/params-collections.md
AlekseyTs Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion proposals/params-collections.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,7 +498,21 @@ the construction of parameter collections when APIs are invoked in their expande

### Metadata

In metadata `params` parameters are marked with `System.ParamArrayAttribute` as `params` arrays are marked today.
In metadata we could mark non-array `params` parameters with `System.ParamArrayAttribute`, as `params` arrays are marked today.
However, it looks like we will be much safer to use a different attribute for non-array `params` parameters.
For example, the current VB compiler will not be able to consume them decorated with `ParamArrayAttribute` neither in normal, nor in expanded form. Therefore, an addition of 'params' modifier is likely to break VB consumers, and very likely consumers from other languages or tools.

Given that, non-array `params` parameters are marked with a new `System.Runtime.CompilerServices.ParamCollectionAttribute`.
```
namespace System.Runtime.CompilerServices
{
[AttributeUsage(AttributeTargets.Parameter, Inherited = true, AllowMultiple = false)]
public sealed class ParamCollectionAttribute : Attribute
{
public ParamCollectionAttribute() { }
}
}
```

## Open questions

Expand Down