Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Word converter: paragraph after table in list not handled properly #441

Closed
jskeet opened this issue Jan 20, 2022 · 4 comments
Closed

Word converter: paragraph after table in list not handled properly #441

jskeet opened this issue Jan 20, 2022 · 4 comments
Assignees
@BillWagner
Labels
type: bug The Standard does not describe the language as intended or implemented type: tools This issue (or PR) relates to a tool, not the Standard
Milestone
C# 6

Comments

@jskeet
Copy link
Contributor

jskeet commented Jan 20, 2022

In 12.9.2 (multiplication operator) there's a table that's expected to be in a list, followed by a paragraph. The paragraph should be part of the list - followed by the next list item beginning "Decimal multiplication"

The Markdown isn't quite right here anyway, but after trying a few things I believe we'll still need more work to get it to format appropriately in Word. (Or we could rearrange the Markdown...)
@jskeet jskeet added type: bug The Standard does not describe the language as intended or implemented type: tools This issue (or PR) relates to a tool, not the Standard labels Jan 20, 2022
@jskeet jskeet added this to the C# 6 milestone Feb 24, 2022
@jskeet
Copy link
Contributor Author

jskeet commented Feb 24, 2022

We need to do something here - that may be rearranging the Markdown, or it may be fixing the tooling, but it needs to be sorted out for C#6.

@BillWagner BillWagner self-assigned this Feb 24, 2022
@BillWagner
Copy link
Member

Adding myself as an assignee to remind myself to take a look at the markdown and see what options we have.

@jskeet
Copy link
Contributor Author

jskeet commented Mar 16, 2022

Not sure that this really needs to be blocking. It's not ideal, but it's not horrific as-is.

@jskeet
Copy link
Contributor Author

jskeet commented Mar 17, 2022

This is fixable without too much hassle. There's a prototype in #512. I'll fix it up when other PRs have been merged.

jskeet added a commit to jskeet/csharpstandard that referenced this issue Mar 18, 2022
@jskeet
Allow custom blocks (tables) to be used in lists
850fe7c 
Enables dotnet#441 to be fixed
jskeet added a commit to jskeet/csharpstandard that referenced this issue Mar 18, 2022
@jskeet
Move tables for arithmetic operations properly inside the tables
40c3207 
This then enables the paragraphs following them to be correctly within the table. This change is just whitespace.

Fixes dotnet#441.

The change around line 5612 is to replace a tab with four spaces.
@jskeet jskeet mentioned this issue Mar 18, 2022
Merged
jskeet added a commit that referenced this issue Mar 18, 2022
@jskeet
Allow custom blocks (tables) to be used in lists
d7644ed 
Enables #441 to be fixed
@jskeet jskeet closed this as completed in 9e6615d Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BillWagner BillWagner

Labels
type: bug The Standard does not describe the language as intended or implemented type: tools This issue (or PR) relates to a tool, not the Standard
Projects
None yet
Milestone
C# 6
Development

No branches or pull requests
2 participants
@jskeet @BillWagner