Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible issue with constructor parameters #782

Closed
BillWagner opened this issue Apr 20, 2023 · 1 comment · Fixed by #1007
Closed

Possible issue with constructor parameters #782

BillWagner opened this issue Apr 20, 2023 · 1 comment · Fixed by #1007
Assignees
@jskeet
Labels
type: bug The Standard does not describe the language as intended or implemented
Milestone
Pre-C# 8.0

Comments

@BillWagner
Copy link
Member

See https://github.com/dotnet/csharpstandard/pull/219/files#r1171850693

The wording doesn't describe if there is any distinction between optional and required parameters in a constructor and if that distinction is considered part of the constructor signature.
@jskeet jskeet added the type: bug The Standard does not describe the language as intended or implemented label Apr 21, 2023
@jskeet
Copy link
Contributor

jskeet commented Apr 21, 2023

Marking as a bug because I believe it is, but I won't put time into this until after we've shipped C# 7, as I don't believe we're in a worse position than we were before.

@BillWagner BillWagner mentioned this issue May 10, 2023
Merged
@jskeet jskeet added this to the Pre-C# 8.0 milestone Sep 21, 2023
jskeet added a commit to jskeet/csharpstandard that referenced this issue Nov 23, 2023
@jskeet
Clarify that optional/required isn't relevant in ctor or indexer sign…
77f09be 
…atures

Fixes dotnet#782.

(I hadn't noticed that the same thing is relevant for indexers.)
@jskeet jskeet mentioned this issue Nov 23, 2023
Merged
jskeet added a commit that referenced this issue Nov 29, 2023
@jskeet
Clarify that optional/required isn't relevant in ctor or indexer sign…
dc288d9 
…atures

Fixes #782.

(I hadn't noticed that the same thing is relevant for indexers.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jskeet jskeet

Labels
type: bug The Standard does not describe the language as intended or implemented
Projects
None yet
Milestone
Pre-C# 8.0
Development

Successfully merging a pull request may close this issue.

Clarify that optional/required isn't relevant in ctor or indexer signatures jskeet/csharpstandard
2 participants
@jskeet @BillWagner