Add example annotation to 3 new examples #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillWagner
approved these changes
Nov 30, 2023
now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@BillWagner, I changed the 2 examples in patterns.md, so they don't need any non-standard supporting types/methods. I believe I have preserved your original intent.
BTW, should you want to add annotations to examples in the future, add the following line right before the line starting the source code, and then replace/delete options as you need (according to https://github.com/dotnet/csharpstandard/blob/standard-v7/tools/ExampleExtractor/ExtractorAndTesterUsersGuide.md):
> <!-- Example: {template:"xxx", name:"xxx", replaceEllipsis:true, customEllipsisReplacements: ["xxx", "xxx"], expectedErrors:["CSxxx"], expectedWarnings:["CSxxx"], ignoredWarnings:["CSxxx"], inferOutput:true, expectedOutput:["xxx"], ignoreOutput:true, expectedException:"xxx", additionalFiles:["xxx.cs"]} -->The leading
>is only needed if the example is inside an Example or Note.