Refactor antlr tool #207
Merged
Refactor antlr tool #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rework the bat file to generate an ANTLR file, and update the grammar in the standard. Note that this does pick up a couple PRs that affected the grammar.
I think this will help us validate the grammar and fix validation errors.
BillWagner
commented
Jan 14, 2021
tools/GetGrammar/grammar.antlr
Outdated
| @@ -0,0 +1,2274 @@ | |||
|
|
|||
| // Source: 7.3.1 General | |||
There was a problem hiding this comment.
@RexJaeschke @jskeet @gafter Will these comments help us to validate the ANTLR grammar? I added them to Rex's work on the grammar extraction tool because they helped me get started. I can leave this output in place if we think it will be useful.
There was a problem hiding this comment.
Regardless of validation, I like the idea of keeping them just to make things easier for anyone reading the standard.
There was a problem hiding this comment.
Yep; looks good to me.
|
Marking this ready for review. See #217 for my proposal on what to do next. /cc @RexJaeschke @jskeet |
jskeet
approved these changes
Jan 28, 2021
| @@ -10,6 +10,7 @@ This annex contains the grammar productions found in the specification, includin | |||
|
|
|||
| ```ANTLR | |||
|
|
|||
| // Source: §7.3.1 General | |||
tools/GetGrammar/Program.cs
Outdated
| while ((inputLine = Console.ReadLine()) != null) | ||
| { | ||
| if (inputLine.Length < 8) // Is it long enough to contain an opening fence? | ||
| while ((inputLine = await inputFile.ReadLineAsync()) != null) |
There was a problem hiding this comment.
I found a new pattern yesterday:
while (await inputFile.ReadLineAsync() is string inputLine)(and remove the earlier declaration).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm making updates to the grammar extraction tool and batch file to make this easier to run as a github action.