-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C# 7.x: Add support for readonly structs #333
Conversation
Should an implicit conversion from |
a249299
to
6d2b5df
Compare
This draft does not reflect the draft specification at https://github.com/dotnet/csharplang/blob/main/proposals/csharp-7.2/span-safety.md |
Reminder to look at #334 for other open issues w.r.t this PR (including Neal's concerns re missing text re span safety). |
Based on Neal’s suggestion during yesterday's TG2 meeting, we agreed to merge as is, but only call |
I'll rebase this branch to resolve conflicts, and mark it ready for review. |
d0d7985
to
0178851
Compare
Assigned to @gafter for the splitting off - we should have assigned this before... |
I've removed ref struct from this PR and moved it to #601. This should be fine for |
044337b
to
739d370
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. Let's
Yup, just done a final review. Will merge now. |
This PR adds one new modifier to structs,
readonly
, in struct_modifier.