Indent lists in notes #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Lists in notes now work... notes in lists are slightly trickier. We lose the extra indentation, but that's not so terrible. |
jskeet
force-pushed
the
list-indentation-in-notes
branch
from
fa6022a to
e92ca53
Compare
|
We also lose the extra indentation for code blocks in notes. We could probably fix that relatively easily if we wanted to, but it would cramp the line lengths further. |
Fixes dotnet#435 (and extract some constants which were duplicated in many places)
jskeet
force-pushed
the
list-indentation-in-notes
branch
from
e92ca53 to
0b40bd7
Compare
|
(Rebase complete.) |
BillWagner
approved these changes
Mar 18, 2022
| yield return paragraph; | ||
| } | ||
| else if (element is Table table) | ||
| { | ||
| if (table.ElementAt(0) is TableProperties tableProperties) | ||
| { | ||
| tableProperties.TableIndentation ??= new TableIndentation(); | ||
| tableProperties.TableIndentation.Width = 540; | ||
| // TODO: This will be incorrect if we ever have a table in a list in a note. | ||
| // Let's just try not to do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #435 (and extract some constants which were duplicated in many places)
I've checked that this looks appropriate in 6.4.3, 8.3.5 and 17.6.2, which were all mentioned in that issue. Given that those ones are fine, I don't expect to see any problems elsewhere.