Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C# 7.x: Adding more support for expression-bodied members #69

Merged
merged 1 commit into from
Jun 8, 2022
Merged

C# 7.x: Adding more support for expression-bodied members #69

merged 1 commit into from
Jun 8, 2022

Conversation

RexJaeschke
Copy link
Contributor

No description provided.

@RexJaeschke RexJaeschke added this to the C# 7.x milestone Dec 14, 2020
@RexJaeschke RexJaeschke mentioned this pull request Feb 11, 2021
Merged
@KalleOlaviNiemitalo KalleOlaviNiemitalo mentioned this pull request Jun 2, 2021
Merged
@RexJaeschke RexJaeschke added the Review: pending Proposal is available for review label Sep 16, 2021
@RexJaeschke RexJaeschke marked this pull request as draft December 4, 2021 18:13
@RexJaeschke RexJaeschke mentioned this pull request Jan 3, 2022
Open
@BillWagner BillWagner force-pushed the Rex-v7-more-expression-bodied-members branch 2 times, most recently from a77ff87 to 98d324f Compare April 2, 2022 20:20
@jskeet jskeet self-assigned this Apr 21, 2022
jskeet
jskeet reviewed May 5, 2022
View reviewed changes
Copy link
Contributor

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically fine, but a few nits and presentation aspects to discuss.

standard/classes.md Outdated Show resolved Hide resolved
standard/classes.md Show resolved Hide resolved
@jskeet jskeet added the meeting: discuss This issue should be discussed at the next TC49-TG2 meeting label May 5, 2022
@jskeet jskeet marked this pull request as ready for review May 5, 2022 09:25
@jskeet
Copy link
Contributor

jskeet commented May 11, 2022

Next steps for Jon:

  • File a new issue for the "corresponds exactly to"
  • Adjust the bulleted list
  • Send out for review

jskeet
jskeet approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tweaked the list wording - I'm now happy for this to be reviewed more widely.

@jskeet
Copy link
Contributor

jskeet commented May 13, 2022

@RexJaeschke: I note this branch now has conflicts with draft-v7. Would you like me to try to resolve them?

@RexJaeschke
Copy link
Contributor Author

@jskeet . Yes please!

@jskeet
Copy link
Contributor

jskeet commented May 13, 2022

@jskeet . Yes please!

Righto - I'll do that on Monday.

@gafter gafter mentioned this pull request May 13, 2022
Open
5 tasks
@RexJaeschke @jskeet
Expand expression-bodied members feature
543595c 
This now includes property accessors, instance constructors, static
constructors and finalizers.
@jskeet jskeet force-pushed the Rex-v7-more-expression-bodied-members branch from 167d183 to 543595c Compare May 16, 2022 08:18
@jskeet
Copy link
Contributor

jskeet commented May 16, 2022

Rebased and squashed to a single commit with a more descriptive message

@jskeet
Copy link
Contributor

jskeet commented May 25, 2022

Ping @BillWagner, @ericlippert, @MadsTorgersen, @Nigel-Ecma for a final review - I'd like to merge soon if possible.

BillWagner
BillWagner approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM.

Lets :shipit:

@jskeet jskeet merged commit c5f9628 into draft-v7 Jun 8, 2022
@jskeet jskeet deleted the Rex-v7-more-expression-bodied-members branch June 8, 2022 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jskeet jskeet jskeet approved these changes

@gafter gafter gafter approved these changes

@BillWagner BillWagner BillWagner approved these changes

@ericlippert ericlippert Awaiting requested review from ericlippert

@MadsTorgersen MadsTorgersen Awaiting requested review from MadsTorgersen

@Nigel-Ecma Nigel-Ecma Awaiting requested review from Nigel-Ecma

Assignees

@jskeet jskeet

Labels
meeting: discuss This issue should be discussed at the next TC49-TG2 meeting Review: pending Proposal is available for review
Projects
None yet
Milestone
C# 7.x
Development

Successfully merging this pull request may close these issues.
4 participants
@RexJaeschke @jskeet @BillWagner @gafter