-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update baseline infra with specifics for deployment-tools repo #1
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,14 +5,10 @@ | |
--> | ||
|
||
<PropertyGroup> | ||
<LibrariesProjectRoot>$([MSBuild]::NormalizeDirectory('$(RepoRoot)', 'src', 'libraries'))</LibrariesProjectRoot> | ||
<CoreClrProjectRoot>$([MSBuild]::NormalizeDirectory('$(RepoRoot)', 'src', 'coreclr'))</CoreClrProjectRoot> | ||
<MonoProjectRoot>$([MSBuild]::NormalizeDirectory('$(RepoRoot)', 'src', 'mono'))</MonoProjectRoot> | ||
<InstallerProjectRoot>$([MSBuild]::NormalizeDirectory('$(RepoRoot)', 'src', 'installer'))</InstallerProjectRoot> | ||
<ClickOnceProjectRoot>$([MSBuild]::NormalizeDirectory('$(RepoRoot)', 'src', 'clickonce'))</ClickOnceProjectRoot> | ||
<RepoToolsLocalDir>$([MSBuild]::NormalizeDirectory('$(RepoRoot)', 'tools-local'))</RepoToolsLocalDir> | ||
<RepoTasksDir>$([MSBuild]::NormalizeDirectory('$(RepoToolsLocalDir)', 'tasks'))</RepoTasksDir> | ||
<IbcOptimizationDataDir>$([MSBuild]::NormalizeDirectory('$(ArtifactsDir)', 'ibc'))</IbcOptimizationDataDir> | ||
<XmlDocDir>$([MSBuild]::NormalizeDirectory('$(ArtifactsBinDir)', 'docs'))</XmlDocDir> | ||
</PropertyGroup> | ||
|
||
<!-- The TFMs to build and test against. --> | ||
|
@@ -33,16 +29,9 @@ | |
<NetFrameworkCurrent>net472</NetFrameworkCurrent> | ||
</PropertyGroup> | ||
|
||
<!-- Honor the generic RuntimeConfiguration property. --> | ||
<!-- Provides a way to override ClickOnce configuration. --> | ||
<PropertyGroup> | ||
<RuntimeConfiguration Condition="'$(RuntimeConfiguration)' == ''">$(Configuration)</RuntimeConfiguration> | ||
<RuntimeConfiguration Condition="'$(RuntimeConfiguration)' == '' AND ('$(Configuration)' == 'Debug' OR '$(Configuration)' == 'Release')">$(Configuration)</RuntimeConfiguration> | ||
<RuntimeConfiguration Condition="'$(RuntimeConfiguration)' == ''">Debug</RuntimeConfiguration> | ||
<CoreCLRConfiguration Condition="'$(CoreCLRConfiguration)' == ''">$(RuntimeConfiguration)</CoreCLRConfiguration> | ||
<MonoConfiguration Condition="'$(MonoConfiguration)' == '' and '$(RuntimeConfiguration.ToLower())' != 'checked'">$(RuntimeConfiguration)</MonoConfiguration> | ||
<!-- There's no checked configuration on Mono. --> | ||
<MonoConfiguration Condition="'$(MonoConfiguration)' == '' and '$(RuntimeConfiguration.ToLower())' == 'checked'">Debug</MonoConfiguration> | ||
<LibrariesConfiguration Condition="'$(LibrariesConfiguration)' == ''">$(Configuration)</LibrariesConfiguration> | ||
<ClickOnceConfiguration Condition="'$(ClickOnceConfiguration)' == ''">$(Configuration)</ClickOnceConfiguration> | ||
</PropertyGroup> | ||
|
||
<PropertyGroup> | ||
|
@@ -56,9 +45,7 @@ | |
<TargetOS Condition="'$(TargetOS)' == '' and $([MSBuild]::IsOSPlatform('SOLARIS'))">Solaris</TargetOS> | ||
<TargetOS Condition="'$(TargetOS)' == '' and $([MSBuild]::IsOSUnixLike())">Linux</TargetOS> | ||
<TargetOS Condition="'$(TargetOS)' == '' and $([MSBuild]::IsOSPlatform('WINDOWS'))">Windows_NT</TargetOS> | ||
<CoreCLRTargetOS Condition="'$(CoreCLRTargetOS)' == ''">$(TargetOS)</CoreCLRTargetOS> | ||
<MonoTargetOS Condition="'$(MonoTargetOS)' == ''">$(TargetOS)</MonoTargetOS> | ||
<LibrariesTargetOS Condition="'$(LibrariesTargetOS)' == ''">$(TargetOS)</LibrariesTargetOS> | ||
<ClickOnceTargetOS Condition="'$(ClickOnceTargetOS)' == ''">$(TargetOS)</ClickOnceTargetOS> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In dotnet/runtime this infra exists because you might want to build a different configuration of coreclr vs. mono vs. libraries, is that necessary here? I think it can be removed. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, this is not needed - will remove it. |
||
</PropertyGroup> | ||
|
||
<PropertyGroup> | ||
|
@@ -67,8 +54,7 @@ | |
|
||
<!--Feature switches --> | ||
<PropertyGroup> | ||
<EnableNgenOptimization Condition="'$(EnableNgenOptimization)' == '' and '$(Configuration)' == 'Release'">true</EnableNgenOptimization> | ||
<!-- Enable NuGet static graph evaluation to optimize incremental restore --> | ||
<RestoreUseStaticGraphEvaluation>true</RestoreUseStaticGraphEvaluation> | ||
</PropertyGroup> | ||
</Project> | ||
</Project> |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,10 +6,7 @@ | |
;; The apphost and comhost are template files, modified by the SDK to produce the executable for FDE | ||
;; and SCD apps. If they are signed, the file that the SDK produces has an invalid signature and | ||
;; can't be signed again. More info at https://github.com/dotnet/core-setup/pull/7549. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Seems like these lines aren't relevant anymore. I think keeping the examples is fine if you think this repo will need this file in the future (launcher.exe?), but otherwise it should be deleted entirely. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Will remove - thanks. |
||
*apphost.exe;;Template, https://github.com/dotnet/core-setup/pull/7549 | ||
*singlefilehost.exe;;Template, https://github.com/dotnet/core-setup/pull/7549 | ||
*comhost.dll;;Template, https://github.com/dotnet/core-setup/pull/7549 | ||
*apphosttemplateapphostexe.exe;;Template, https://github.com/dotnet/core-setup/pull/7549 | ||
*comhosttemplatecomhostdll.dll;;Template, https://github.com/dotnet/core-setup/pull/7549 | ||
*staticapphosttemplateapphostexe.exe;;Template, https://github.com/dotnet/core-setup/pull/7549 | ||
*dotnet.js;;Workaround, https://github.com/dotnet/core-eng/issues/9933 | ||
|
||
;; Examples: | ||
;; *apphost.exe;;Template, https://github.com/dotnet/core-setup/pull/7549 | ||
;; *apphosttemplateapphostexe.exe;;Template, https://github.com/dotnet/core-setup/pull/7549 |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,61 +26,14 @@ | |
<BundleInstallerEngineArtifact Include="$(ArtifactsPackagesDir)**/*engine.exe" /> | ||
<BundleInstallerExeArtifact Include="$(ArtifactsPackagesDir)**/*.exe" /> | ||
|
||
<!-- apphost and comhost template files are not signed, by design. --> | ||
<FileSignInfo Include="apphost.exe;singlefilehost.exe;comhost.dll" CertificateName="None" /> | ||
</ItemGroup> | ||
|
||
<ItemGroup Condition="'$(CrossTargetComponentFolder)' != ''"> | ||
<CoreCLRCrossTargetItemsToSign Include="$(CoreCLRArtifactsPath)$(CrossTargetComponentFolder)/sharedFramework/*.dll" /> | ||
<CoreCLRCrossTargetItemsToSign Include="$(CoreCLRArtifactsPath)$(CrossTargetComponentFolder)/sharedFramework/*.exe" /> | ||
<!-- launcher is not signed, by design. --> | ||
<FileSignInfo Include="launcher.exe" CertificateName="None" /> | ||
</ItemGroup> | ||
|
||
<ItemGroup Condition="'$(SignBinaries)' == 'true'"> | ||
<!-- Sign CoreCLR. --> | ||
<ItemsToSign Include="$(CoreCLRSharedFrameworkDir)*.dll" /> | ||
<ItemsToSign Include="$(CoreCLRSharedFrameworkDir)*.exe" /> | ||
|
||
<ItemsToSign Include="$(CoreCLRArtifactsPath)System.Private.CoreLib.dll" /> | ||
|
||
<ItemsToSign Include="$(CoreCLRCrossgen2Dir)crossgen2.exe" /> | ||
<ItemsToSign Include="$(CoreCLRCrossgen2Dir)crossgen2.dll" /> | ||
<ItemsToSign Include="$(CoreCLRCrossgen2Dir)ILCompiler.DependencyAnalysisFramework.dll" /> | ||
<ItemsToSign Include="$(CoreCLRCrossgen2Dir)ILCompiler.ReadyToRun.dll" /> | ||
<ItemsToSign Include="$(CoreCLRCrossgen2Dir)ILCompiler.TypeSystem.ReadyToRun.dll" /> | ||
<ItemsToSign Include="$(CoreCLRCrossgen2Dir)jitinterface.dll" /> | ||
|
||
<ItemsToSign Condition="'$(TargetOS)' == 'Windows_NT'" Include="$(CoreCLRCrossgen2Dir)clrjit-win-$(TargetArchitecture).dll" /> | ||
<ItemsToSign Condition="'$(TargetOS)' != 'Windows_NT'" Include="$(CoreCLRCrossgen2Dir)clrjit-unix-$(TargetArchitecture).dll" /> | ||
|
||
<ItemsToSign Include="@(CoreCLRCrossTargetItemsToSign)" /> | ||
|
||
<FileSignInfo Include="mscordaccore.dll" CertificateName="MicrosoftSHA2" /> | ||
|
||
<!-- Sign api-ms-win-core-xstate-l2-1-0 binary as it is only catalog signed in the current SDK. --> | ||
<ItemsToSign | ||
Condition="'$(Configuration)' == 'Release' and '$(TargetArchitecture)' == 'x86'" | ||
Include="$(CoreCLRArtifactsPath)Redist\ucrt\DLLs\$(TargetArchitecture)\api-ms-win-core-xstate-l2-1-0.dll" /> | ||
|
||
<!-- Sign libraries. --> | ||
<ItemsToSign Include="$(LibrariesNativeArtifactsPath)*.dll" /> | ||
<ItemsToSign Include="$(LibrariesSharedFrameworkRefArtifactsPath)*.dll" /> | ||
<!-- Most runtime artifacts will be crossgenned, so sign them post-crossgen. mscorlib isn't. --> | ||
<ItemsToSign Include="$(LibrariesSharedFrameworkBinArtifactsPath)mscorlib.dll" /> | ||
|
||
<!-- Sign the host. --> | ||
<ItemsToSign Include="$(BaseOutputRootPath)corehost/**/hostfxr.dll" /> | ||
<ItemsToSign Include="$(BaseOutputRootPath)corehost/**/hostpolicy.dll" /> | ||
<ItemsToSign Include="$(BaseOutputRootPath)corehost/**/dotnet.exe" /> | ||
<ItemsToSign Include="$(BaseOutputRootPath)corehost/**/ijwhost.dll" /> | ||
<ItemsToSign Include="$(BaseOutputRootPath)corehost/**/nethost.dll" /> | ||
|
||
<!-- Sign managed libraries in installer subset. --> | ||
<ItemsToSign Include="$(ArtifactsBinDir)Microsoft.NET.HostModel/**/*.dll" /> | ||
</ItemGroup> | ||
|
||
<!-- Sign ready-to-run binaries after crossgen is applied. --> | ||
<ItemGroup Condition="'$(SignR2RBinaries)' == 'true'"> | ||
<ItemsToSign Include="$(CrossGenRootPath)**/*.dll" /> | ||
<!-- Sign ClickOnce binaries. --> | ||
<!--ItemsToSign Include="$(ArtifactsBinDir)Mage/**/*.dll" /--> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Delete? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixing. |
||
</ItemGroup> | ||
|
||
<ItemGroup Condition="'$(SignMsiFiles)' == 'true'"> | ||
|
@@ -108,11 +61,6 @@ | |
<ItemsToSign Include="$(DownloadDirectory)**\*.rpm" /> | ||
</ItemGroup> | ||
|
||
<ItemGroup> | ||
<!-- External files --> | ||
<ItemsToSign Remove="@(ItemsToSign->WithMetadataValue('Filename', 'Newtonsoft.Json'))" /> | ||
</ItemGroup> | ||
|
||
<ItemGroup> | ||
<ItemsToSign Update="@(ItemsToSign)" Authenticode="$(CertificateId)" /> | ||
</ItemGroup> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stick to space rather than
-
, like readme?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure - sounds good.