Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parse dotnet trace providers option #2730

Merged
merged 4 commits into from
Nov 22, 2021

Conversation

itn3000
Copy link
Contributor

@itn3000 itn3000 commented Nov 4, 2021

This will fix #2691

Copy link
Member

@hoyosjs hoyosjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @itn3000. I've added the sample from your issue into a test and caught one more little thing. Thanks for fixing this.

@mikelle-rogers would you mind checking this too, please?

@hoyosjs
Copy link
Member

hoyosjs commented Nov 21, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@hoyosjs
Copy link
Member

hoyosjs commented Nov 22, 2021

Thanks @itn3000 !

@hoyosjs hoyosjs merged commit 7ebf1c1 into dotnet:main Nov 22, 2021
@itn3000 itn3000 deleted the fix-parse-dotnet-trace-providers branch November 23, 2021 05:06
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyValue arguments in "dotnet-trace collect --providers" is not parsed correctly.
2 participants