Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dotnet/installer #3370

Merged
merged 9 commits into from
Oct 4, 2022
2 changes: 2 additions & 0 deletions Directory.Build.targets
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
<!-- This file is to prevent implicit imports from breaking out of the repo root. -->
<Project />
15 changes: 15 additions & 0 deletions eng/AuxMsbuildFiles/Directory.Build.props
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
<Project>
<!-- Importing arcade depends on the existence of a global.json. Fix
this to a set of well known imports when moving to Helix. -->
<Import Project="Sdk.props" Sdk="Microsoft.DotNet.Arcade.Sdk" />
<Import Project="$([MSBuild]::GetPathOfFileAbove('Directory.Build.props', '$(MSBuildThisFileDirectory)../'))" />

<PropertyGroup>
<BaseOutputPath>bin\</BaseOutputPath>
<BaseIntermediateOutputPath>obj\</BaseIntermediateOutputPath>
<OutputPath Condition="'$(PlatformName)' == 'AnyCPU'">$(BaseOutputPath)$(Configuration)\</OutputPath>
<OutputPath Condition="'$(PlatformName)' != 'AnyCPU'">$(BaseOutputPath)$(PlatformName)\$(Configuration)\</OutputPath>
<IntermediateOutputPath Condition="'$(PlatformName)' == 'AnyCPU'">$(BaseIntermediateOutputPath)$(Configuration)\</IntermediateOutputPath>
<IntermediateOutputPath Condition="'$(PlatformName)' != 'AnyCPU'">$(BaseIntermediateOutputPath)$(PlatformName)\$(Configuration)\</IntermediateOutputPath>
</PropertyGroup>
</Project>
5 changes: 5 additions & 0 deletions eng/AuxMsbuildFiles/Directory.Build.targets
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<Project>
<Import Project="Sdk.targets" Sdk="Microsoft.DotNet.Arcade.Sdk" />
<Import Project="$([MSBuild]::GetPathOfFileAbove('Directory.Build.targets', '$(MSBuildThisFileDirectory)../'))" />
<Import Project="SdkPackOverrides.targets"/>
</Project>
27 changes: 27 additions & 0 deletions eng/AuxMsbuildFiles/SdkPackOverrides.targets
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
<Project InitialTargets="OverrideTestingVersions">
<Target Name="OverrideTestingVersions">
<ItemGroup>
<KnownFrameworkReference>
<TargetingPackVersion Condition="'%(TargetFramework)' == 'net6.0'">$(MicrosoftNETCoreApp60Version)</TargetingPackVersion>
<LatestRuntimeFrameworkVersion Condition="'%(TargetFramework)' == 'net6.0'">$(MicrosoftNETCoreApp60Version)</LatestRuntimeFrameworkVersion>
</KnownFrameworkReference>
<KnownAppHostPack>
<AppHostPackVersion Condition="'%(TargetFramework)' == 'net6.0'">$(MicrosoftNETCoreApp60Version)</AppHostPackVersion>
</KnownAppHostPack>
<KnownCrossgen2Pack>
<Crossgen2PackVersion Condition="'%(TargetFramework)' == 'net6.0'">$(MicrosoftNETCoreApp60Version)</Crossgen2PackVersion>
</KnownCrossgen2Pack>
<KnownRuntimePack>
<LatestRuntimeFrameworkVersion Condition="'%(TargetFramework)' == 'net6.0'">$(MicrosoftNETCoreApp60Version)</LatestRuntimeFrameworkVersion>
</KnownRuntimePack>

<KnownFrameworkReference>
<TargetingPackVersion Condition="'%(TargetFramework)' == 'netcoreapp3.1'">$(MicrosoftNETCoreApp31Version)</TargetingPackVersion>
<LatestRuntimeFrameworkVersion Condition="'%(TargetFramework)' == 'netcoreapp3.1'">$(MicrosoftNETCoreApp31Version)</LatestRuntimeFrameworkVersion>
</KnownFrameworkReference>
<KnownAppHostPack>
<AppHostPackVersion Condition="'%(TargetFramework)' == 'netcoreapp3.1'">$(MicrosoftNETCoreApp31Version)</AppHostPackVersion>
</KnownAppHostPack>
</ItemGroup>
</Target>
</Project>
4 changes: 2 additions & 2 deletions eng/Version.Details.xml
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>ccfe6da198c5f05534863bbb1bff66e830e0c6ab</Sha>
</Dependency>
<Dependency Name="Microsoft.Dotnet.Sdk.Internal" Version="7.0.100-rc.2.22454.1">
<Dependency Name="Microsoft.Dotnet.Sdk.Internal" Version="7.0.100-rtm.22480.6">
<Uri>https://github.com/dotnet/installer</Uri>
<Sha>330dee39e5e4dcf765f4c41c76b94c8e4497e91c</Sha>
<Sha>61f59eff2c102046b8b2f6df9c0605ef3b7f6d63</Sha>
</Dependency>
<Dependency Name="Microsoft.AspNetCore.App.Ref.Internal" Version="7.0.0-rtm.22501.6">
<Uri>https://github.com/dotnet/aspnetcore</Uri>
Expand Down
4 changes: 2 additions & 2 deletions eng/Versions.props
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
<MicrosoftAspNetCoreAppRefInternalVersion>7.0.0-rtm.22501.6</MicrosoftAspNetCoreAppRefInternalVersion>
<MicrosoftAspNetCoreAppRefVersion>7.0.0-rtm.22501.6</MicrosoftAspNetCoreAppRefVersion>
<!-- dotnet/installer: Testing version of the SDK. Needed for the signed & entitled host. -->
<MicrosoftDotnetSdkInternalVersion>7.0.100-rc.2.22454.1</MicrosoftDotnetSdkInternalVersion>
<MicrosoftDotnetSdkInternalVersion>7.0.100-rtm.22480.6</MicrosoftDotnetSdkInternalVersion>
</PropertyGroup>
<PropertyGroup>
<!-- Runtime versions to test -->
Expand All @@ -34,7 +34,7 @@
<MicrosoftAspNetCoreApp60Version>$(MicrosoftNETCoreApp60Version)</MicrosoftAspNetCoreApp60Version>
<!-- The SDK runtime version used to build single-file apps (currently hardcoded) -->
<SingleFileRuntime60Version>6.0.8</SingleFileRuntime60Version>
<SingleFileRuntimeLatestVersion>7.0.0-rc.1.22422.12</SingleFileRuntimeLatestVersion>
<SingleFileRuntimeLatestVersion>7.0.0-rtm.22478.9</SingleFileRuntimeLatestVersion>
</PropertyGroup>
<PropertyGroup>
<!-- Opt-in/out repo features -->
Expand Down
4 changes: 2 additions & 2 deletions src/Directory.Build.targets
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<?xml version="1.0" encoding="utf-8"?>
<Project>
<Import Project="Sdk.targets" Sdk="Microsoft.DotNet.Arcade.Sdk" />
<Import Project="Sdk.targets" Sdk="Microsoft.DotNet.Arcade.Sdk" />

<!-- Work around https://github.com/dotnet/sourcelink/issues/572
<!-- Work around https://github.com/dotnet/sourcelink/issues/572
Remove once we build using an SDK that contains https://github.com/dotnet/sdk/pull/10613 -->
<PropertyGroup>
<TargetFrameworkMonikerAssemblyAttributesPath>$([System.IO.Path]::Combine('$(IntermediateOutputPath)','$(TargetFrameworkMoniker).AssemblyAttributes$(DefaultLanguageSourceExtension)'))</TargetFrameworkMonikerAssemblyAttributesPath>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ public override DotNetBuildDebuggeeTestStep ConfigureDotNetBuildDebuggeeTask(Tes
string logPath = GetLogPath(config, framework, runtimeIdentifier, debuggeeName);
return new CsprojBuildDebuggeeTestStep(dotNetPath,
initialSourceDirPath,
config.DebuggeeMsbuildAuxRoot,
GetDebuggeeNativeLibDirPath(config, debuggeeName),
GetBuildProperties(config, runtimeIdentifier),
runtimeIdentifier,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ public class CsprojBuildDebuggeeTestStep : DotNetBuildDebuggeeTestStep
/// </param>
public CsprojBuildDebuggeeTestStep(string dotnetToolPath,
string templateSolutionDirPath,
string debuggeeMsbuildAuxRoot,
string debuggeeNativeLibDirPath,
Dictionary<string,string> buildProperties,
string runtimeIdentifier,
Expand All @@ -43,6 +44,7 @@ public CsprojBuildDebuggeeTestStep(string dotnetToolPath,
string logPath) :
base(dotnetToolPath,
templateSolutionDirPath,
debuggeeMsbuildAuxRoot,
debuggeeNativeLibDirPath,
debuggeeSolutionDirPath,
debuggeeProjectDirPath,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ public abstract class DotNetBuildDebuggeeTestStep : TestStep
/// </param>
public DotNetBuildDebuggeeTestStep(string dotnetToolPath,
string templateSolutionDirPath,
string debuggeeMsbuildAuxRoot,
string debuggeeNativeLibDirPath,
string debuggeeSolutionDirPath,
string debuggeeProjectDirPath,
Expand All @@ -85,6 +86,7 @@ public DotNetBuildDebuggeeTestStep(string dotnetToolPath,
{
DotNetToolPath = dotnetToolPath;
DebuggeeTemplateSolutionDirPath = templateSolutionDirPath;
DebuggeeMsbuildAuxRoot = debuggeeMsbuildAuxRoot;
DebuggeeNativeLibDirPath = debuggeeNativeLibDirPath;
DebuggeeSolutionDirPath = debuggeeSolutionDirPath;
DebuggeeProjectDirPath = debuggeeProjectDirPath;
Expand All @@ -109,6 +111,10 @@ public DotNetBuildDebuggeeTestStep(string dotnetToolPath,
/// </summary>
public string DebuggeeTemplateSolutionDirPath { get; private set; }
/// <summary>
/// The path containing supporting msbuild files for the build
/// </summary>
public string DebuggeeMsbuildAuxRoot { get; }
/// <summary>
/// The path where the debuggee's native binary dependencies will be copied from.
/// </summary>
public string DebuggeeNativeLibDirPath { get; private set; }
Expand All @@ -117,6 +123,7 @@ public DotNetBuildDebuggeeTestStep(string dotnetToolPath,
/// the debuggee project directory.
/// </summary>
public string DebuggeeSolutionDirPath { get; private set; }

/// <summary>
/// The path where the primary debuggee executable project directory will be created. For single project solutions this
/// will be identical to the debuggee solution directory.
Expand Down Expand Up @@ -158,6 +165,7 @@ void PrepareProjectSolution(ITestOutputHelper output)
output.WriteLine("{");
IndentedTestOutputHelper indentedOutput = new IndentedTestOutputHelper(output);
CopySourceDirectory(DebuggeeTemplateSolutionDirPath, DebuggeeSolutionDirPath, indentedOutput);
CopySourceDirectory(DebuggeeMsbuildAuxRoot, DebuggeeSolutionDirPath, indentedOutput);
CreateNuGetConfig(indentedOutput);
output.WriteLine("}");
output.WriteLine("");
Expand Down
8 changes: 8 additions & 0 deletions src/Microsoft.Diagnostics.TestHelpers/TestConfiguration.cs
Original file line number Diff line number Diff line change
Expand Up @@ -637,6 +637,14 @@ public string DebuggeeSourceRoot
get { return MakeCanonicalPath(GetValue("DebuggeeSourceRoot")); }
}

/// <summary>
/// Auxiliary properties used by CLI based test projects file will be fetched from this path and copied to DebuggeeSourceRoot
/// </summary>
public string DebuggeeMsbuildAuxRoot
{
get { return MakeCanonicalPath(GetValue("DebuggeeMsbuildAuxRoot")); }
}

/// <summary>
/// Debuggee final sources/project file/binary outputs will be placed here: <DebuggeeBuildRoot>/<DebuggeeName>/
/// </summary>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
<BuildProjectFrameworkLatest Condition="StartsWith('$(RuntimeVersionLatest)', '3.1')">netcoreapp3.1</BuildProjectFrameworkLatest>

<DebuggeeSourceRoot>$(RepoRootDir)/src/SOS/SOS.UnitTests/Debuggees</DebuggeeSourceRoot>
<DebuggeeMsbuildAuxRoot>$(RepoRootDir)/eng/AuxMsbuildFiles</DebuggeeMsbuildAuxRoot>
<DebuggeeBuildProcess>sdk.prebuilt</DebuggeeBuildProcess>
<DebuggeeBuildRoot>$(RootBinDir)</DebuggeeBuildRoot>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
<DesktopFramework>net462</DesktopFramework>

<DebuggeeSourceRoot>$(RepoRootDir)\src\SOS\SOS.UnitTests\Debuggees</DebuggeeSourceRoot>
<DebuggeeMsbuildAuxRoot>$(RepoRootDir)\eng\AuxMsbuildFiles</DebuggeeMsbuildAuxRoot>
<DebuggeeBuildProcess>sdk.prebuilt</DebuggeeBuildProcess>
<DebuggeeBuildRoot>$(RootBinDir)</DebuggeeBuildRoot>

Expand Down
3 changes: 2 additions & 1 deletion src/SOS/SOS.UnitTests/Debuggees/Directory.Build.props
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<Project>
<Import Project="$(MSBuildThisFileDirectory)..\..\..\Directory.Build.props"/>

<Import Project="$(RepoRoot)/eng/AuxMsbuildFiles/SdkPackOverrides.targets"/>
hoyosjs marked this conversation as resolved.
Show resolved Hide resolved

<PropertyGroup>
<DebugType Condition="'$(TargetFramework)' == 'net462'">full</DebugType>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

<TestProduct>ProjectK</TestProduct>
<DebuggeeSourceRoot>$(RepoRootDir)/src/tests</DebuggeeSourceRoot>
<DebuggeeMsbuildAuxRoot>$(RepoRootDir)/eng/AuxMsbuildFiles</DebuggeeMsbuildAuxRoot>
<DebuggeeBuildProcess>cli</DebuggeeBuildProcess>
<DebuggeeBuildProcess>sdk.prebuilt</DebuggeeBuildProcess>
<DebuggeeBuildRoot>$(RootBinDir)</DebuggeeBuildRoot>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

<TestProduct>ProjectK</TestProduct>
<DebuggeeSourceRoot>$(RepoRootDir)\src\tests</DebuggeeSourceRoot>
<DebuggeeMsbuildAuxRoot>$(RepoRootDir)\eng\AuxMsbuildFiles</DebuggeeMsbuildAuxRoot>
<DebuggeeBuildProcess>sdk.prebuilt</DebuggeeBuildProcess>
<DebuggeeBuildRoot>$(RootBinDir)</DebuggeeBuildRoot>
<CliPath>$(DotNetRoot)\dotnet.exe</CliPath>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@

<TestProduct>ProjectK</TestProduct>
<DebuggeeSourceRoot>$(RepoRootDir)\src\tests\DbgShim.UnitTests\Debuggees</DebuggeeSourceRoot>
<DebuggeeMsbuildAuxRoot>$(RepoRootDir)\eng\AuxMsbuildFiles</DebuggeeMsbuildAuxRoot>
<DebuggeeBuildProcess>cli</DebuggeeBuildProcess>
<DebuggeeName>SimpleDebuggee</DebuggeeName>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

<TestProduct>ProjectK</TestProduct>
<DebuggeeSourceRoot>$(RepoRootDir)\src\tests\DbgShim.UnitTests\Debuggees</DebuggeeSourceRoot>
<DebuggeeMsbuildAuxRoot>$(RepoRootDir)\eng\AuxMsbuildFiles</DebuggeeMsbuildAuxRoot>
<DebuggeeBuildProcess>cli</DebuggeeBuildProcess>
<DebuggeeName>SimpleDebuggee</DebuggeeName>

Expand Down