Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SB metadata to intermediates #4487

Merged
merged 3 commits into from
Feb 2, 2024

Conversation

ellahathaway
Copy link
Member

The changes in this pull request aim to improve the UX and guideance around the SourceBuild metadata by placing the metadata on explicit source-build intermediates.

The changes include:

  • Removing existing SourceBuild metadata from all non-intermediate dependencies.
  • Defining new explicit intermediate dependencies and adding SourceBuild metadata to those dependencies.

Related to dotnet/source-build#3373 and dotnet/source-build#4073

@ellahathaway
Copy link
Member Author

@mthalman Are you able to merge this for me? I can't do it myself since I'm not an authorized user. Thanks in advance!

eng/Versions.props Outdated Show resolved Hide resolved
@mthalman
Copy link
Member

mthalman commented Feb 2, 2024

@mthalman Are you able to merge this for me? I can't do it myself since I'm not an authorized user. Thanks in advance!

I don't have permission

@MichaelSimons
Copy link
Member

@mthalman Are you able to merge this for me? I can't do it myself since I'm not an authorized user. Thanks in advance!

I don't have permission

I can merge it for you.

@MichaelSimons MichaelSimons merged commit 05ee3cf into dotnet:main Feb 2, 2024
19 checks passed
@ellahathaway ellahathaway deleted the sb-metadata branch February 2, 2024 20:58
@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants