Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add AllowUnsafeBlocks supports for source code based metadata generation #10175

Merged

Conversation

filzrev
Copy link
Contributor

@filzrev filzrev commented Aug 30, 2024

This PR intended to fix #10174.

When generating metadata from source files.
MSBuild properties need to be mapped to related property.

Currently DefineConstants is supported.
This PR add AllowUnsafeBlocks property support for C# source build (VB don't support unsafe)

Copy link
Contributor

@yufeih yufeih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @filzrev !

@yufeih yufeih added the bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note label Sep 14, 2024
@yufeih yufeih merged commit 3ef4172 into dotnet:main Sep 14, 2024
7 checks passed
@yufeih yufeih added new-feature Makes the pull request to appear in "New Features" section of the next release note and removed bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note labels Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature Makes the pull request to appear in "New Features" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add support for AllowUnsafeBlocks in properties
2 participants