fix: change link as plaintext if API is excluded #10300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filzrev
force-pushed
the
fix-excluded-symbol-link
branch
from
23318fa to
73501b5
Compare
yufeih
added
bug
yufeih
reviewed
Oct 19, 2024
filzrev
force-pushed
the
fix-excluded-symbol-link
branch
from
8964df5 to
db035fe
Compare
yufeih
approved these changes
Oct 19, 2024
|
Thank you for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intended to fix problem reported at #10287.
When class is excluded. link target document is not exists.
So link to excluded symbol should be rendered as plain text.
What's changed in this PR
It needs
SymbolFilter::IncludeApiinstance to check specific symbol is excluded or not.So it need to pass
SymbolFilterinstance to API that generate URL.SymbolFilter filterparameter to several APIs.urlgeneration logics to checkfilter.IncludeApi(symbol)and set null when symbol is excluded.SymbolVisitorAdapter adapterparameter (that seems not be used).Test
Tested on local environment with following output formats.
mrefmarkdownapiPage