Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use PlantUML Online Server as default configs #10395

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

filzrev
Copy link
Contributor

@filzrev filzrev commented Nov 17, 2024

This PR change PlantUmlOptions default settings.

Background
When using PlantUML diagrams.
It need to explicitly set build/markdownEngineProperties/plantuml configs.
https://dotnet.github.io/docfx/docs/markdown.html#settings

Currently when above config is not defined. following exception is thrown.

error PlantUmlExtension: Value cannot be null. (Parameter 'uriString')

This PR change default settings to use PlantUML Online server as default options.

Copy link
Contributor

@yufeih yufeih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@yufeih yufeih added the new-feature Makes the pull request to appear in "New Features" section of the next release note label Nov 18, 2024
@yufeih yufeih changed the title chore: Use PlantUML Online Server as default configs feat: Use PlantUML Online Server as default configs Nov 18, 2024
@yufeih yufeih merged commit f35a47a into dotnet:main Nov 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature Makes the pull request to appear in "New Features" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants