Add basic static rendering #3411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yufeih
requested review from
928PJY,
herohua,
live1206,
mingwli,
OsmondJiang and
superyyrrzz
as code owners
superyyrrzz
reviewed
Sep 12, 2018
| [InlineData("image.png", true, false, ContentType.Resource, "image.png", "/image.png", "image.png")] | ||
| [InlineData("a&#/b\\.* d.png", true, false, ContentType.Resource, "a&#/b\\.* d.png", "/a&#/b/.* d.png", "a&#/b/.* d.png")] | ||
| [InlineData("a.md", false, false, ContentType.Page, "a/index.html", "/a/", "a/")] | ||
| [InlineData("a.md", false, true, ContentType.Page, "a.html", "/a", "a")] |
There was a problem hiding this comment.
"a.html", "/a", "a" [](start = 59, length = 19)
should this be "a.html", "/a.html", "a.html"?
live1206
reviewed
Sep 12, 2018
src/docfx/config/OutputConfig.cs
Outdated
|
|
||
| /// <summary> | ||
| /// Gets whether to include `.html` in urls. | ||
| /// The default value is to generate an `index.html` for each article. |
There was a problem hiding this comment.
The default value is to generate an
index.htmlfor each article. [](start = 12, length = 66)
Is this comment for Json?
There was a problem hiding this comment.
clarified in comments
superyyrrzz
reviewed
Sep 12, 2018
| output = await Template.Render(model); | ||
| } | ||
|
|
||
| return (errors, output, dependencies.Build()); |
There was a problem hiding this comment.
output [](start = 28, length = 6)
this can be PageModel or string, but Build.cs always uses context.WriteJson to write it. Add a context.WriteString when it's string?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3376 #2865