Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module init for docfx.Test #5041

Merged
merged 1 commit into from
Aug 29, 2019
Merged

Add module init for docfx.Test #5041

merged 1 commit into from
Aug 29, 2019

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented Aug 29, 2019

Before C# had a way to implement module initializes dotnet/csharplang#2608, use Fody for now.

Microsoft Reviewers: Open in CodeFlow

@yufeih yufeih added the v3 label Aug 29, 2019
@codecov
Copy link

codecov bot commented Aug 29, 2019

Codecov Report

Merging #5041 into v3 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               v3    #5041   +/-   ##
=======================================
  Coverage   92.96%   92.96%           
=======================================
  Files         185      185           
  Lines        7591     7591           
=======================================
  Hits         7057     7057           
  Misses        534      534

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2422e32...a87c29e. Read the comment docs.

@VSC-Service-Account
Copy link

Integration Test Result

edge-developer (00:00:29.4832772, 0 more diff)
diff --git "a/D:/Docs.Build.TestData\\output\\edge-developer/.errors.log" "b/D:/Docs.Build.TestData\\.temp\\edge-developer/.errors.log"
index be787c91ab..c33ca472b3 100644
--- "a/D:/Docs.Build.TestData\\output\\edge-developer/.errors.log"
+++ "b/D:/Docs.Build.TestData\\.temp\\edge-developer/.errors.log"
@@ -4,6 +4,38 @@
   "message": "Metadata validation ruleset used: default",
   "code": "MetadataValidationRuleset"
 }
+{
+  "message_severity": "suggestion",
+  "log_item_type": "user",
+  "code": "author-missing",
+  "message": "Missing required attribute: 'author'. Add the current author's GitHub ID. NOTE: This Suggestion will be elevated to a Warning on 9/1/2019.",
+  "file": "microsoft-edge/dev-guide/understanding-leaks.md",
+  "line": 2
+}
+{
+  "message_severity": "suggestion",
+  "log_item_type": "user",
+  "code": "author-missing",
+  "message": "Missing required attribute: 'author'. Add the current author's GitHub ID. NOTE: This Suggestion will be elevated to a Warning on 9/1/2019.",
+  "file": "microsoft-edge/devtools-guide/devtools_software-license-terms.md",
+  "line": 2
+}
+{
+  "message_severity": "suggestion",
+  "log_item_type": "user",
+  "code": "author-missing",
+  "message": "Missing required attribute: 'author'. Add the current author's GitHub ID. NOTE: This Suggestion will be elevated to a Warning on 9/1/2019.",
+  "file": "microsoft-edge/devtools-guide/devtools-preview_software-license-terms.md",
+  "line": 2
+}
+{
+  "message_severity": "suggestion",
+  "log_item_type": "user",
+  "code": "title-missing",
+  "message": "Missing required attribute: 'title'. Add a title string to show in search engine results. NOTE: This Suggestion will be elevated to a Warning on 9/1/2019.",
+  "file": "microsoft-edge/dev-guide/understanding-leaks.md",
+  "line": 2
+}
 {
   "message_severity": "warning",
   "log_item_type": "user",
DevSandbox (00:00:09.9659743, 0 more diff)
docs-help-pr (00:00:16.4422278, 3091 more diff)
diff --git "a/D:/Docs.Build.TestData\\output\\docs-help-pr/.errors.log" "b/D:/Docs.Build.TestData\\.temp\\docs-help-pr/.errors.log"
index e316a80b3f..d0f1836322 100644
--- "a/D:/Docs.Build.TestData\\output\\docs-help-pr/.errors.log"
+++ "b/D:/Docs.Build.TestData\\.temp\\docs-help-pr/.errors.log"
@@ -44,6 +44,3286 @@
   "file": "help-content/localization/TOC.md",
   "line": 7
 }
+{
+  "message_severity": "suggestion",
+  "log_item_type": "user",
+  "code": "author-missing",
+  "message": "Missing required attribute: 'author'. Add the current author's GitHub ID. NOTE: This Suggestion will be elevated to a Warning on 9/1/2019.",
+  "file": "help-content/contribute/contribute-how-to-write-loc-aka-ms-links.md",
+  "line": 2
+}
+{
+  "message_severity": "suggestion",
+  "log_item_type": "user",
+  "code": "author-missing",
+  "message": "Missing required attribute: 'author'. Add the current author's GitHub ID. NOTE: This Suggestion will be elevated to a Warning on 9/1/2019.",
+  "file": "help-content/contribute/training/git-github-workflow-tutorial.md",
+  "line": 0
+}
+{
+  "message_severity": "suggestion",
+  "log_item_type": "user",
+  "code": "author-missing",
+  "message": "Missing required attribute: 'author'. Add the current author's GitHub ID. NOTE: This Suggestion will be elevated to a Warning on 9/1/2019.",
+  "file": "help-content/contribute/training/samplefiles/samplefile1.md",
+  "line": 0
+}
+{
+  "message_severity": "suggestion",
+  "log_item_type": "user",
+  "code": "author-missing",
+  "message": "Missing required attribute: 'author'. Add the current author's GitHub ID. NOTE: This Suggestion will be elevated to a Warning on 9/1/2019.",
+  "file": "help-content/contribute/training/samplefiles/samplefile2.md",
+  "line": 0
+}
+{
+  "message_severity": "suggestion",
+  "log_item_type": "user",
+  "code": "author-missing",
+  "message": "Missing required attribute: 'author'. Add the current author's GitHub ID. NOTE: This Suggestion will be elevated to a Warning on 9/1/2019.",
+  "file": "help-content/contribute/training/samplefiles/samplefile3.md",
+  "line": 0
+}
+{
+  "message_severity": "suggestion",
+  "log_item_type": "user",
+  "code": "author-missing",
+  "message": "Missing required attribute: 'author'. Add the current author's GitHub ID. NOTE: This Suggestion will be elevated to a Warning on 9/1/2019.",
+  "file": "help-content/contribute/training/samplefiles/samplefile4.md",
+  "line": 0
+}
+{
+  "message_severity": "suggestion",
+  "log_item_type": "user",
+  "code": "author-missing",
+  "message": "Missing required attribute: 'author'. Add the current author's GitHub ID. NOTE: This Suggestion will be elevated to a Warning on 9/1/2019.",
+  "file": "help-content/contribute/training/samplefiles/samplefile5.md",
+  "line": 0
+}
+{
+  "message_severity": "suggestion",
+  "log_item_type": "user",
+  "code": "author-missing",
+  "message": "Missing required attribute: 'author'. Add the current author's GitHub ID. NOTE: This Suggestion will be elevated to a Warning on 9/1/2019.",
+  "file": "help-content/contribute/training/samplefiles/samplefile6.md",
+  "line": 0
+}
+{
+  "message_severity": "suggestion",
+  "log_item_type": "user",
+  "code": "author-missing",
+  "message": "Missing required attribute: 'author'. Add the current author's GitHub ID. NOTE: This Suggestion will be elevated to a Warning on 9/1/2019.",
+  "file": "help-content/contribute/training/samplefiles/samplefile7.md",
+  "line": 0
+}
+{
+  "message_severity": "suggestion",
+  "log_item_type": "user",
+  "code": "author-missing",
+  "message": "Missing required attribute: 'author'. Add the current author's GitHub ID. NOTE: This Suggestion will be elevated to a Warning on 9/1/2019.",
+  "file": "help-content/contribute/training/samplefiles/samplefile8.md",
+  "line": 0
+}
+{
+  "message_severity": "suggestion",
+  "log_item_type": "user",
+  "code": "author-missing",
+  "message": "Missing required attribute: 'author'. Add the current author's GitHub ID. NOTE: This Suggestion will be elevated to a Warning on 9/1/2019.",
+  "file": "help-content/contribute/training/samplefiles/samplefile9.md",
+  "line": 0
+}
+{
+  "message_severity": "suggestion",
+  "log_item_type": "user",
+  "code": "author-missing",
+  "message": "Missing required attribute: 'author'. Add the current author's GitHub ID. NOTE: This Suggestion will be elevated to a Warning on 9/1/2019.",
+  "file": "help-content/contribute/training/training-prerequisites.md",
+  "line": 0
+}
+{
+  "message_severity": "suggestion",
+  "log_item_type": "user",
+  "code": "author-missing",
+  "message": "Missing required attribute: 'author'. Add the current author's GitHub ID. NOTE: This Suggestion will be elevated to a Warning on 9/1/2019.",
+  "file": "help-content/contribute-ref/cheatsheet-reference-content.md",
+  "line": 0
+}
+{
+  "message_severity": "suggestion",
+  "log_item_type": "user",
+  "code": "author-missing",
+  "message": "Missing required attribute: 'author'. Add the current author's GitHub ID. NOTE: This Suggestion will be elevated to a Warning on 9/1/2019.",
+  "file": "help-content/contribute-ref/contribute-ref-get-started-how-ref-autogen-works.md",
+  "line": 0
+}
+{
+  "message_severity": "suggestion",
+  "log_item_type": "user",
+  "code": "author-missing",
+  "message": "Missing required attribute: 'author'. Add the current author's GitHub ID. NOTE: This Suggestion will be elevated to a Warning on 9/1/2019.",
+  "file": "help-content/contribute-ref/contribute-ref-get-started-overview.md",
+  "line": 0
+}
+{
+  "message_severity": "suggestion",
+  "log_item_type": "user",
+  "code": "author-missing",
+  "message": "Missing required attribute: 'author'. Add the current author's GitHub ID. NOTE: This Suggestion will be elevated to a Warning on 9/1/2019.",
+  "file": "help-content/contribute-ref/contribute-ref-get-started-ref-content.md",
+  "line": 0
+}
+{
+  "message_severity": "suggestion",
+  "log_item_type": "user",
+  "code": "author-missing",
+  "message": "Missing required attribute: 'author'. Add the current author's GitHub ID. NOTE: This Suggestion will be elevated to a Warning on 9/1/2019.",
+  "file": "help-content/contribute-ref/contribute-ref-get-started-ref-devs.md",
+  "line": 0
+}
+{
+  "message_severity": "suggestion",
+  "log_item_type": "user",
+  "code": "author-missing",
+  "message": "Missing required attribute: 'author'. Add the current author's GitHub ID. NOTE: This Suggestion will be elevated to a Warning on 9/1/2019.",
+  "file": "help-content/contribute-ref/contribute-ref-get-started-understanding-swagger.md",
+  "line": 0
+}
+{
+  "message_severity": "suggestion",
+  "log_item_type": "user",
+  "code": "author-missing",
+  "message": "Missing required attribute: 'author'. Add the current author's GitHub ID. NOTE: This Suggestion will be elevated to a Warning on 9/1/2019.",
+  "file": "help-content/contribute-ref/contribute-ref-how-to-add-and-stage-overwrites.md",
+  "line": 0
+}
+{
+  "message_severity": "suggestion",
+  "log_item_type": "user",
+  "code": "author-missing",
+  "message": "Missing required attribute: 'author'. Add the current author's GitHub ID. NOTE: This Suggestion will be elevated to a Warning on 9/1/2019.",
+  "file": "help-content/contribute-ref/contribute-ref-how-to-tag-code-examples.md",
+  "line": 0
+}
+{
+  "message_severity": "suggestion",
+  "log_item_type": "user",
+  "code": "author-missing",
+  "message": "Missing required attribute: 'author'. Add the current author's GitHub ID. NOTE: This Suggestion will be elevated to a Warning on 9/1/2019.",
+  "file": "help-content/contribute-ref/contribute-ref-how-to-update-swagger.md",
+  "line": 0
+}
+{
+  "message_severity": "suggestion",
+  "log_item_type": "user",
+  "code": "author-missing",
+  "message": "Missing required attribute: 'author'. Add the current author's GitHub ID. NOTE: This Suggestion will be elevated to a Warning on 9/1/2019.",
+  "file": "help-content/contribute-ref/contribute-ref-how-to-use-constructors.md",
+  "line": 0
+}
+{
+  "message_severity": "suggestion",
+  "log_item_type": "user",
+  "code": "author-missing",
+  "message": "Missing required attribute: 'author'. Add the current author's GitHub ID. NOTE: This Suggestion will be elevated to a Warning on 9/1/2019.",
+  "file": "help-content/contribute-ref/contribute-ref-how-to-use-overwrites.md",
+  "line": 0
+}
+{
+  "message_severity": "suggestion",
+  "log_item_type": "user",
+  "code": "author-missing",
+  "message": "Missing required attribute: 'author'. Add the current author's GitHub ID. NOTE: This Suggestion will be elevated to a Warning on 9/1/2019.",
+  "file": "help-content/contribute-ref/contribute-ref-how-to-write-.NET-docs.md",
+  "line": 0
+}
azure-docs-pr (00:01:15.0958355, 0 more diff)
diff --git "a/D:/Docs.Build.TestData\\output\\azure-docs-pr/.errors.log" "b/D:/Docs.Build.TestData\\.temp\\azure-docs-pr/.errors.log"
index 6c0a9594a5..263f3962fe 100644
--- "a/D:/Docs.Build.TestData\\output\\azure-docs-pr/.errors.log"
+++ "b/D:/Docs.Build.TestData\\.temp\\azure-docs-pr/.errors.log"
@@ -13,54 +13,6 @@ To fix this error either change the JSON to a JSON primitive value (e.g. string,
   "file": "articles/virtual-network/virtual-network-tcpip-performance-tuning.md",
   "line": 6
 }
-{
-  "message_severity": "suggestion",
-  "log_item_type": "user",
-  "code": "author-missing",
-  "message": "Missing required attribute: 'author'. Add the current author's GitHub ID. NOTE: This Suggestion will be elevated to a Warning on 9/1/2019.",
-  "file": "articles/azure-maps/how-to-use-best-practices-for-search.md",
-  "line": 2
-}
-{
-  "message_severity": "suggestion",
-  "log_item_type": "user",
-  "code": "author-missing",
-  "message": "Missing required attribute: 'author'. Add the current author's GitHub ID. NOTE: This Suggestion will be elevated to a Warning on 9/1/2019.",
-  "file": "articles/third-party-notices.md",
-  "line": 2
-}
-{
-  "message_severity": "suggestion",
-  "log_item_type": "user",
-  "code": "author-missing",
-  "message": "Missing required attribute: 'author'. Add the current author's GitHub ID. NOTE: This Suggestion will be elevated to a Warning on 9/1/2019.",
-  "file": "articles/virtual-machine-scale-sets/virtual-machine-scale-sets-autoscale.md",
-  "line": 0
-}
-{
-  "message_severity": "suggestion",
-  "log_item_type": "user",
-  "code": "multiple-values",
-  "message": "Expected type 'String, Null' but got 'Array'. NOTE: This Suggestion will be elevated to a Warning on 9/1/2019.",
-  "file": "articles/virtual-network/virtual-network-tcpip-performance-tuning.md",
-  "line": 6
-}
-{
-  "message_severity": "suggestion",
-  "log_item_type": "user",
-  "code": "title-missing",
-  "message": "Missing required attribute: 'title'. Add a title string to show in search engine results. NOTE: This Suggestion will be elevated to a Warning on 9/1/2019.",
-  "file": "articles/third-party-notices.md",
-  "line": 2
-}
-{
-  "message_severity": "suggestion",
-  "log_item_type": "user",
-  "code": "title-missing",
-  "message": "Missing required attribute: 'title'. Add a title string to show in search engine results. NOTE: This Suggestion will be elevated to a Warning on 9/1/2019.",
-  "file": "articles/virtual-machine-scale-sets/virtual-machine-scale-sets-autoscale.md",
-  "line": 0
-}
 {
   "message_severity": "warning",
   "log_item_type": "user",
Dynamics-365-Operations (00:00:40.6663381, 0 more diff)
SCCMDocs-pr (00:00:17.4360846, 0 more diff)
SCCMDocs-pr.zh-cn (00:00:10.5286716, 0 more diff)
office-dev-O365API (00:00:07.1258955, 0 more diff)
CordovaDocs (00:00:28.3420110, 0 more diff)

Copy link
Contributor

@live1206 live1206 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yufeih yufeih merged commit caaae68 into dotnet:v3 Aug 29, 2019
@yufeih yufeih deleted the module-init branch August 29, 2019 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants