Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found two bug in the CopyInherited class.
Operating System: Windows
DocFX Version Used: 2.58.9
Template used: default
1. NullReferenceException exception crash
Steps to Reproduce:
Expected Behavior:
Inheritdoc will be ignored(hopefully warning would be thrown).
Actual Behavior:
Program crashes with NullReferenceException.
Suggesting fix:
Add null check(line 45) before getting last item from Inheritance list(line 49)
2. StackOverflow crash
Steps to Reproduce:
Expected Behavior:
Documentation would be successfully generated.
Actual Behavior:
Program crashes with StackOverflow.
Suggesting fix:
Add check(line 131) when copying from src to dest if it is the same in order to stop recursion.