Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for including explicit interface implementations #8446

Closed
wants to merge 2 commits into from

Conversation

mikernet
Copy link
Contributor

Adds includeExplicitInterfaceImplementations metadata option which allows including explicit interface implementations without exposing all private members.

@mikernet mikernet force-pushed the include-eii-option branch 2 times, most recently from 78f0a9f to 7134965 Compare February 24, 2023 16:20
@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Patch coverage: 28.57% and project coverage change: -0.03 ⚠️

Comparison is base (cabaa2f) 77.28% compared to head (fe1215e) 77.26%.

❗ Current head fe1215e differs from pull request most recent head d089685. Consider uploading reports for the commit d089685 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8446      +/-   ##
==========================================
- Coverage   77.28%   77.26%   -0.03%     
==========================================
  Files         858      858              
  Lines       30649    30663      +14     
==========================================
+ Hits        23688    23691       +3     
- Misses       6961     6972      +11     
Impacted Files Coverage Δ
src/Microsoft.DocAsCode.Dotnet/SymbolFilter.cs 82.25% <9.09%> (-15.79%) ⬇️
src/Microsoft.DocAsCode.Dotnet/DotnetApiCatalog.cs 96.29% <100.00%> (+0.06%) ⬆️
...de.Dotnet/ExtractMetadata/ExtractMetadataConfig.cs 100.00% <100.00%> (ø)
...crosoft.DocAsCode.Dotnet/MetadataJsonItemConfig.cs 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mikernet
Copy link
Contributor Author

@yufeih Could you review this for suitability before I go too far into testing?

Copy link
Contributor

@yufeih yufeih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The contract and draft implementation looks good for adding unit testing here

src/Microsoft.DocAsCode.Dotnet/SymbolFilter.cs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants