Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add an option to disable new tabs in modern template #8718

Merged
merged 2 commits into from
May 4, 2023
Merged

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented May 4, 2023

Support suppressing the new tab behavior through a new _disableNewTab metadata. The default behavior is to open external links in a new tab and prefer an option to have a default value of false.

fixes #8714

@yufeih yufeih added the bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note label May 4, 2023
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e2c800a) 76.91% compared to head (285e124) 76.92%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8718   +/-   ##
=======================================
  Coverage   76.91%   76.92%           
=======================================
  Files         606      606           
  Lines       25057    25057           
=======================================
+ Hits        19273    19274    +1     
+ Misses       5784     5783    -1     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yufeih yufeih closed this May 4, 2023
@yufeih yufeih reopened this May 4, 2023
@yufeih yufeih closed this May 4, 2023
@yufeih yufeih reopened this May 4, 2023
@yufeih yufeih merged commit 6d80b63 into main May 4, 2023
@yufeih yufeih deleted the disableNewTab branch May 4, 2023 06:42
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
* fix: add an option to disable new tabs in modern template

* test(snapshot): update snapshots for 0a19fd4

---------

Co-authored-by: yufeih <yufeih@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] "_enableNewTab": false has no effect in modern template
1 participant