Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add output config overridable by --output #8727

Merged
merged 2 commits into from
May 4, 2023
Merged

feat: add output config overridable by --output #8727

merged 2 commits into from
May 4, 2023

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented May 4, 2023

  • add a new output JSON config to build and pdf command overridable by --output command line args
  • make docfx init generate output as _site and dest as empty
  • publish seed project to https://dotnet.github.io/docfx/seed

fixes #8339

@yufeih yufeih added the new-feature Makes the pull request to appear in "New Features" section of the next release note label May 4, 2023
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Patch coverage: 63.63% and project coverage change: -0.01 ⚠️

Comparison is base (6d80b63) 76.92% compared to head (73428b9) 76.91%.

❗ Current head 73428b9 differs from pull request most recent head 8d1036f. Consider uploading reports for the commit 8d1036f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8727      +/-   ##
==========================================
- Coverage   76.92%   76.91%   -0.01%     
==========================================
  Files         606      606              
  Lines       25057    25064       +7     
==========================================
+ Hits        19275    19279       +4     
- Misses       5782     5785       +3     
Impacted Files Coverage Δ
src/Microsoft.DocAsCode.App/RunPdf.cs 0.00% <0.00%> (ø)
src/docfx/Models/InitCommand.cs 0.00% <0.00%> (ø)
.../Microsoft.DocAsCode.App/Config/BuildJsonConfig.cs 86.11% <100.00%> (+0.39%) ⬆️
src/Microsoft.DocAsCode.App/RunBuild.cs 65.21% <100.00%> (+3.31%) ⬆️
src/docfx/Models/DefaultCommand.cs 91.42% <100.00%> (+0.51%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yufeih yufeih merged commit e7baaee into main May 4, 2023
@yufeih yufeih deleted the outdir branch May 4, 2023 15:05
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature Makes the pull request to appear in "New Features" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Output folder option always appends _site
1 participant