Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix pdf documentation #8758

Merged
merged 1 commit into from
May 10, 2023
Merged

docs: fix pdf documentation #8758

merged 1 commit into from
May 10, 2023

Conversation

Lulalaby
Copy link
Contributor

formatting and wrong comma

formatting and wrong comma
@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (de20cac) 76.95% compared to head (158c158) 76.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8758   +/-   ##
=======================================
  Coverage   76.95%   76.95%           
=======================================
  Files         606      606           
  Lines       25054    25054           
=======================================
+ Hits        19280    19281    +1     
+ Misses       5774     5773    -1     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Lulalaby
Copy link
Contributor Author

image
oh well nice..

@Lulalaby Lulalaby changed the title docs: fix pdf docs docs: fix pdf documentation May 10, 2023
@Lulalaby
Copy link
Contributor Author

image
i guess this works only for non-fork prs?

@yufeih
Copy link
Contributor

yufeih commented May 10, 2023

i guess this works only for non-fork prs?
Seems so, there is some instability problem with the snapshot test which I'm about to fix.

Copy link
Contributor

@yufeih yufeih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Lulalaby!

@yufeih yufeih merged commit df88270 into dotnet:main May 10, 2023
@Lulalaby Lulalaby deleted the patch-1 branch May 10, 2023 13:16
@yufeih yufeih added the documentation Improvements or additions to documentation and the project website label May 16, 2023
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
docs: fix pdf docs

formatting and wrong comma
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation and the project website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants