Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: re-render mermaid diagrams on tab switch #8814

Merged
merged 2 commits into from
Jun 1, 2023
Merged

fix: re-render mermaid diagrams on tab switch #8814

merged 2 commits into from
Jun 1, 2023

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented May 31, 2023

fixes #8757

@yufeih yufeih added the bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note label May 31, 2023
@yufeih yufeih force-pushed the mm-tab branch 3 times, most recently from 7d3a633 to 3b97ccc Compare May 31, 2023 09:36
@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (6d91d6c) 76.84% compared to head (9f7b1be) 76.83%.

❗ Current head 9f7b1be differs from pull request most recent head f146a94. Consider uploading reports for the commit f146a94 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8814      +/-   ##
==========================================
- Coverage   76.84%   76.83%   -0.02%     
==========================================
  Files         606      606              
  Lines       25041    25041              
==========================================
- Hits        19243    19240       -3     
- Misses       5798     5801       +3     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yufeih yufeih closed this Jun 1, 2023
@yufeih yufeih reopened this Jun 1, 2023
@yufeih yufeih merged commit db8ab17 into main Jun 1, 2023
@yufeih yufeih deleted the mm-tab branch June 1, 2023 04:02
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Mermaid flowcharts won't generate for tabs
1 participant