Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: specify global metadata with -m|--metadata arg #8816

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented Jun 1, 2023

Support specifying global metadata through the -m or --metadata command line argument, e.g., docfx build --metadata _appTitle="My App 1":

  • Set multiple metadata by passing multiple --metadata args
  • true and false are parsed as boolean
  • The value of true can be omitted, e.g, docfx build --metadata _disableContribution

fixes #8787

@yufeih yufeih added the new-feature Makes the pull request to appear in "New Features" section of the next release note label Jun 1, 2023
@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Patch coverage: 22.22% and project coverage change: -0.03 ⚠️

Comparison is base (3e73134) 76.84% compared to head (ab7a529) 76.82%.

❗ Current head ab7a529 differs from pull request most recent head b4964d9. Consider uploading reports for the commit b4964d9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8816      +/-   ##
==========================================
- Coverage   76.84%   76.82%   -0.03%     
==========================================
  Files         606      606              
  Lines       25041    25050       +9     
==========================================
+ Hits        19243    19244       +1     
- Misses       5798     5806       +8     
Impacted Files Coverage Δ
src/docfx/Models/BuildCommand.cs 40.38% <12.50%> (-5.07%) ⬇️
src/docfx/Models/BuildCommandOptions.cs 90.47% <100.00%> (+0.47%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yufeih yufeih merged commit f28165a into main Jun 2, 2023
@yufeih yufeih deleted the cmd-metadata branch June 2, 2023 01:43
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature Makes the pull request to appear in "New Features" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fileMetadataFiles etc not supported as command line options
1 participant