Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: theme button not refreshed on change #8853

Merged
merged 2 commits into from
Jun 9, 2023
Merged

fix: theme button not refreshed on change #8853

merged 2 commits into from
Jun 9, 2023

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented Jun 9, 2023

fixes #8851

@yufeih yufeih added the bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note label Jun 9, 2023
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (c7b4ad5) 77.00% compared to head (5d3342a) 76.99%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8853      +/-   ##
==========================================
- Coverage   77.00%   76.99%   -0.01%     
==========================================
  Files         605      605              
  Lines       25036    25036              
==========================================
- Hits        19278    19277       -1     
- Misses       5758     5759       +1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yufeih yufeih closed this Jun 9, 2023
@yufeih yufeih reopened this Jun 9, 2023
@yufeih yufeih merged commit 96b71ec into main Jun 9, 2023
@yufeih yufeih deleted the fix-theme-refresh branch June 9, 2023 08:48
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
* fix: theme button not refreshed on change

* test(snapshot): update snapshots for d50ff6a

---------

Co-authored-by: yufeih <yufeih@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Template bug - Modern Template - Switching themes doesn't update the icon
1 participant