chore: add System.Text.Json attributes #9341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 1 file with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
yufeih
added
the
engineering
|
Does |
It can't automatically generate schema from C# code that use custom |
p-kostov
pushed a commit
to ErpNetDocs/docfx
that referenced
this pull request
Jun 28, 2024
* chore: add JsonExtensionData attribute of System.Text.Json * chore: add JsonIgnore attribute of System.Text.Json * chore: add JsonConstructor attribute of System.Text.Json * chore: add Newtonsoft.Json namespace qualifier of JsonConverter * chore: add JsonPropertyName attribute of System.Text.Json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What included in this PR
This PR add following System.Text.Json's attributes to existing Newtonsoft.Json based models.
JsonPropertyNameJsonIgnoreJsonExtensionDataJsonConstructorWhat's tested on my local environment
In this PR. attributes are manually added.
So I've verified attributes are aligned with existing
Newtonsoft.Jsonvalue with reflection API.Background
This PR is intended to be used for #8968. (Because
JsonSchema.Netsupport onlySystem.Text.Jsonattributes)So JsonConverter for
System.Text.Jsonis not added in this PR.To fully migrate to
System.Text.Json. #8137 to be resolved.