Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ApiPage is not generated when multiple namespaces defined across projects #9647

Closed

Conversation

filzrev
Copy link
Contributor

@filzrev filzrev commented Jan 24, 2024

This PR is intended to fix #9618.

On current implementation.
CreateNamespaceToc returns only first namespace that is processed.

This PR removing idExists check for CreateNamespaceToc.
It's because Namespace with same id can be defined by multiple projects.

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e2f78e9) 74.31% compared to head (8c91a60) 74.32%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/Docfx.Dotnet/DotnetApiCatalog.Toc.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9647   +/-   ##
=======================================
  Coverage   74.31%   74.32%           
=======================================
  Files         536      536           
  Lines       23179    23177    -2     
  Branches     4054     4054           
=======================================
  Hits        17226    17226           
+ Misses       4851     4849    -2     
  Partials     1102     1102           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@filzrev
Copy link
Contributor Author

filzrev commented Jan 24, 2024

It can generate .md files successfully by this PR.
But after running docfx build command. TOC entries are duplicated.
It's needs to implement tock merge inside CreateNamespaceToc method.

@filzrev filzrev closed this Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] docfx metadata does not generate all metadata on Ubuntu
1 participant