Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update YamlDotNet version #9654

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Conversation

filzrev
Copy link
Contributor

@filzrev filzrev commented Jan 25, 2024

This PR update YamlDotNet version to 15.1.0.

In this release. Following breaking changes are announced.

Breaking: For those that get impacted pass in NullNamingConvention.Instance to the EnumNamingConvetion arguments on the constructor
Breaking: Removed many of the redundant constructors for the classes, pass in the old default values to the new constructors
I've modified following parts.

So I've applied following changed in this PR.

  1. Add NullNamingConvention.Instance args for TypeConverter.ChangeType method
  2. Add NullNamingConvention.Instance args for following type constructors.
    2.1. ScalarNodeDeserializer
    2.2. CollectionNodeDeserializer
    2.3. NodeValueDeserializer
  3. Add missing args for following type constructors
    3.1. JsonEventEmitter
    3.2. TypeAssigningEventEmitter

The completed parameters are taken from the following code changes.
aaubry/YamlDotNet@88a9189

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (e2f78e9) 74.31% compared to head (61473a5) 74.32%.
Report is 2 commits behind head on main.

Files Patch % Lines
...eDeserializers/ExtensibleObjectNodeDeserializer.cs 50.00% 1 Missing ⚠️
src/Docfx.YamlSerialization/YamlSerializer.cs 90.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9654   +/-   ##
=======================================
  Coverage   74.31%   74.32%           
=======================================
  Files         536      536           
  Lines       23179    23187    +8     
  Branches     4054     4054           
=======================================
+ Hits        17226    17234    +8     
  Misses       4851     4851           
  Partials     1102     1102           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yufeih yufeih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @filzrev !

@yufeih yufeih added the engineering Makes the pull request to appear in the "Engineering" section of the next release note label Jan 26, 2024
@yufeih yufeih merged commit aff89bf into dotnet:main Jan 26, 2024
8 checks passed
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
chore-update-yaml-dot-net-version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering Makes the pull request to appear in the "Engineering" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants