Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add docfx JSON Schema files and related tests #9852

Merged
merged 3 commits into from
Apr 12, 2024

Conversation

filzrev
Copy link
Contributor

@filzrev filzrev commented Apr 9, 2024

This PR intended to fix #8968.

What's included in this PR

  1. Add following JSON schema files to schemas directory.
  • docfx.schema.json
  • toc.schema.json
  • filterconfig.schema.json
  • xrefmap.schema.json
  1. Add related JSON schema test code for json/yml files.

Remaining tasks
Following tasks will be handled by another PRs.

  1. Add $schema URL to existing docfx.json files. (It's used for intellisense completion)
  2. Create PR to update SchemaStore's JSON Schema for docfx.
    (SchemaStore's JSON schema files are used if $schema URL is not specified)
  3. Add schema validation logics when loading docfx.json config. (For better syntax error reporting)
  4. Reorganize Config Reference page contents based on JSON schema.
  5. Support enum values as case invariant.

JSON Schema related issues

Copy link
Contributor

@yufeih yufeih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Thank you @filzrev 💯

@yufeih yufeih changed the title chore: Add docfx JSON Schema files and related tests feat: Add docfx JSON Schema files and related tests Apr 11, 2024
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.98%. Comparing base (fe673ec) to head (d858890).
Report is 118 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9852      +/-   ##
==========================================
+ Coverage   74.31%   78.98%   +4.66%     
==========================================
  Files         536      538       +2     
  Lines       23189    23323     +134     
  Branches     4056     4049       -7     
==========================================
+ Hits        17234    18421    +1187     
+ Misses       4853     3774    -1079     
- Partials     1102     1128      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yufeih yufeih merged commit 89e294c into dotnet:main Apr 12, 2024
7 checks passed
filzrev added a commit to filzrev/docfx that referenced this pull request Apr 14, 2024
chore: add json schema files and related tests

Co-authored-by: Yufei Huang <yufeih@live.com>
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
chore: add json schema files and related tests

Co-authored-by: Yufei Huang <yufeih@live.com>
renovate bot added a commit to buehler/dotnet-operator-sdk that referenced this pull request Jul 1, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [docfx](https://github.com/dotnet/docfx) | `2.76.0` -> `2.77.0` |
[![age](https://developer.mend.io/api/mc/badges/age/nuget/docfx/2.77.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/docfx/2.77.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/docfx/2.76.0/2.77.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/docfx/2.76.0/2.77.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>dotnet/docfx (docfx)</summary>

### [`v2.77.0`](https://github.com/dotnet/docfx/releases/tag/v2.77.0)

<!-- Release notes generated using configuration in .github/release.yml
at main -->

#### What's Changed

##### 💥 Breaking Changes

- chore: Drop .NET 7 SDK supports by
[@&#8203;filzrev](https://github.com/filzrev) in
[dotnet/docfx#9911

##### 🎉 New Features

- feat: Enable PreferCSSPageSize option for PDF generation by
[@&#8203;filzrev](https://github.com/filzrev) in
[dotnet/docfx#9850
- feat: Add docfx JSON Schema files and related tests by
[@&#8203;filzrev](https://github.com/filzrev) in
[dotnet/docfx#9852
- feat: Add `toc.json` transform logics using `toc.extension.js` by
[@&#8203;filzrev](https://github.com/filzrev) in
[dotnet/docfx#9953
- feat: Better error when link not found by
[@&#8203;Patrick8639](https://github.com/Patrick8639) in
[dotnet/docfx#9957
- feat: Add `categoryLayout` option for metadata generation by
[@&#8203;filzrev](https://github.com/filzrev) in
[dotnet/docfx#9965
- feat: Permits to specify the placement of overwrites by
[@&#8203;Patrick8639](https://github.com/Patrick8639) in
[dotnet/docfx#9937
- feat: Support private symbols by
[@&#8203;Patrick8639](https://github.com/Patrick8639) in
[dotnet/docfx#9972
- feat: Add support for gzipped xrefmap that stored as local file by
[@&#8203;filzrev](https://github.com/filzrev) in
[dotnet/docfx#9966
- feat: Enable view transitions feature by
[@&#8203;filzrev](https://github.com/filzrev) in
[dotnet/docfx#9909

##### 🐞 Bug Fixes

- fix: PDF `Producer` document information by
[@&#8203;filzrev](https://github.com/filzrev) in
[dotnet/docfx#9851
- fix: Xrefmap baseUrl problem reported at
[#&#8203;9866](https://github.com/dotnet/docfx/issues/9866) by
[@&#8203;filzrev](https://github.com/filzrev) in
[dotnet/docfx#9869
- fix: Xref links are not resolved on docs site by
[@&#8203;filzrev](https://github.com/filzrev) in
[dotnet/docfx#9880
- fix: Change same URL check logic to case invariant by
[@&#8203;filzrev](https://github.com/filzrev) in
[dotnet/docfx#9883
- fix: Improve unresolved xref messages by
[@&#8203;filzrev](https://github.com/filzrev) in
[dotnet/docfx#9884
- fix: Fix nightly build errors by
[@&#8203;filzrev](https://github.com/filzrev) in
[dotnet/docfx#9913
- fix: TOC filter value is not shared between pages by
[@&#8203;filzrev](https://github.com/filzrev) in
[dotnet/docfx#9912
- fix: Build problems when running .NET 6 version of docfx on some
environment by [@&#8203;filzrev](https://github.com/filzrev) in
[dotnet/docfx#9922
- fix: `docfx metadata` command throw `ArgumentException` when
referencing empty namespace by doc comment by
[@&#8203;filzrev](https://github.com/filzrev) in
[dotnet/docfx#10023
- fix: serve url link by
[@&#8203;WeihanLi](https://github.com/WeihanLi) in
[dotnet/docfx#10035

##### 🚀 Performance Improvements

- perf: Change serializer for XrefMap from NewtonsoftJson to
System.Text.Json by [@&#8203;filzrev](https://github.com/filzrev) in
[dotnet/docfx#9872
- perf: Remove some enum boxing in GlobMatcher by
[@&#8203;lahma](https://github.com/lahma) in
[dotnet/docfx#10051
- perf: Optimize CountWordInText by
[@&#8203;lahma](https://github.com/lahma) in
[dotnet/docfx#10050

##### 🔧 Engineering

- chore: Skip unstable SVG content check that returned from PlantUML
Online Server by [@&#8203;filzrev](https://github.com/filzrev) in
[dotnet/docfx#9858
- deps: Update Spectre.Console package versions by
[@&#8203;filzrev](https://github.com/filzrev) in
[dotnet/docfx#9894
- chore: fix NU5129 warning on `dotnet pack` command by
[@&#8203;filzrev](https://github.com/filzrev) in
[dotnet/docfx#9942
- chore: Add PolySharp libarary to use latest C# syntax by
[@&#8203;filzrev](https://github.com/filzrev) in
[dotnet/docfx#9960
- chore: Add snapshot update workflow by
[@&#8203;filzrev](https://github.com/filzrev) in
[dotnet/docfx#9969
- chore: Remove unused workflow settings by
[@&#8203;filzrev](https://github.com/filzrev) in
[dotnet/docfx#10030

##### 📄 Documentation

- docs: Fix typo by
[@&#8203;carlos-regis](https://github.com/carlos-regis) in
[dotnet/docfx#9871
- docs: Fix URL in markdown and match to html example by
[@&#8203;si618](https://github.com/si618) in
[dotnet/docfx#9881
- docs: Fix documentation site build warnings by
[@&#8203;filzrev](https://github.com/filzrev) in
[dotnet/docfx#9895
- docs: Fix missing docfx.json config docs by
[@&#8203;filzrev](https://github.com/filzrev) in
[dotnet/docfx#9935
- docs: Fix Docfx.App nuget package usage document by
[@&#8203;filzrev](https://github.com/filzrev) in
[dotnet/docfx#9994
- docs: Fix plugin related docs and logs by
[@&#8203;filzrev](https://github.com/filzrev) in
[dotnet/docfx#10029

#### New Contributors

- [@&#8203;carlos-regis](https://github.com/carlos-regis) made their
first contribution in
[dotnet/docfx#9871
- [@&#8203;si618](https://github.com/si618) made their first
contribution in
[dotnet/docfx#9881
- [@&#8203;Patrick8639](https://github.com/Patrick8639) made their
first contribution in
[dotnet/docfx#9957

**Full Changelog**:
dotnet/docfx@v2.76.0...v2.77.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 9pm,before 6am" in timezone
Europe/Zurich, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/buehler/dotnet-operator-sdk).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature Makes the pull request to appear in "New Features" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add official json schema definition for docfx.json and toc.json
2 participants