Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poor documentation #1818

Closed
ibondy opened this issue Oct 12, 2024 · 2 comments · Fixed by #1867
Closed

Poor documentation #1818

ibondy opened this issue Oct 12, 2024 · 2 comments · Fixed by #1867
Assignees
@IEvangelist
Labels
doc-bug Problem with the content; needs to be fixed [org][type][category] documentation Improvements or additions to documentation in-pr okr-health okr-quality Content-health KR: Concerns article defects/freshness or build warnings. Pri1 High priority, do before Pri2 and Pri3 📌 seQUESTered Identifies that an issue has been imported into Quest. 📦 release-9.0 Used to track doc updates for release 9.0 of .NET Aspire.
Milestone
9.0

Comments

@ibondy
Copy link

ibondy commented Oct 12, 2024 •
edited by sequestor bot
Loading

Directions for this sample are incorrect.
AddAzureStorage extension is referencing package Aspire.Hosting.Azure.Storage which is not imported.
Completely missing OrleansContracts project.
This sample is not easy to follow and require a bunch of trouble shooting to make it work.
Reference to samples repository would be helpful.

Associated WorkItem - 340544
@dotnetrepoman dotnetrepoman bot added the ⌚ Not Triaged Not triaged label Oct 12, 2024
@IEvangelist
Copy link
Member

Hi @ibondy - What page is this referring to?

@IEvangelist IEvangelist added the needs-more-info Needs more info from OP. Auto-closed after 2 weeks if no response. [org][resolution] label Oct 14, 2024
@ibondy
Copy link
Author

ibondy commented Oct 14, 2024

https://learn.microsoft.com/en-us/dotnet/aspire/frameworks/orleans?tabs=dotnet-cli

@github-actions github-actions bot removed the needs-more-info Needs more info from OP. Auto-closed after 2 weeks if no response. [org][resolution] label Oct 14, 2024
@IEvangelist IEvangelist self-assigned this Oct 16, 2024
@IEvangelist IEvangelist added documentation Improvements or additions to documentation 🗺️ reQUEST Triggers an issue to be imported into Quest. Pri1 High priority, do before Pri2 and Pri3 doc-bug Problem with the content; needs to be fixed [org][type][category] okr-quality Content-health KR: Concerns article defects/freshness or build warnings. 📦 release-9.0 Used to track doc updates for release 9.0 of .NET Aspire. and removed ⌚ Not Triaged Not triaged labels Nov 5, 2024
@IEvangelist IEvangelist added this to the 9.0 milestone Nov 5, 2024
IEvangelist added a commit that referenced this issue Nov 5, 2024
@IEvangelist
Edit pass on the Orleans content. Also, fixes #1818
e473341
@IEvangelist IEvangelist mentioned this issue Nov 5, 2024
Merged
@sequestor sequestor bot added 📌 seQUESTered Identifies that an issue has been imported into Quest. and removed 🗺️ reQUEST Triggers an issue to be imported into Quest. labels Nov 6, 2024
IEvangelist added a commit that referenced this issue Nov 11, 2024
@IEvangelist
Edit pass on the Orleans content. Also, fixes #1818
e0c0651
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in dotnet/docs November 2024 sprint Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IEvangelist IEvangelist

Labels
doc-bug Problem with the content; needs to be fixed [org][type][category] documentation Improvements or additions to documentation in-pr okr-health okr-quality Content-health KR: Concerns article defects/freshness or build warnings. Pri1 High priority, do before Pri2 and Pri3 📌 seQUESTered Identifies that an issue has been imported into Quest. 📦 release-9.0 Used to track doc updates for release 9.0 of .NET Aspire.
Projects
No open projects
dotnet/docs November 2024 sprint
Status: ✅ Done
Milestone
9.0
Development

Successfully merging a pull request may close this issue.

.NET Aspire 9.0 - GA Release content dotnet/docs-aspire
2 participants
@ibondy @IEvangelist