Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebToolsE2E][Multiple docs] Some instructions need to be updated in "Tutorial: Deploy a .NET Aspire project with a SQL Server Database to Azure" #2017

Closed
v-reinawang opened this issue Nov 7, 2024 · 1 comment · Fixed by #1867
Assignees
Labels
deployment Content related to deployment. doc-bug Problem with the content; needs to be fixed [org][type][category] in-pr okr-health okr-quality Content-health KR: Concerns article defects/freshness or build warnings. Pri1 High priority, do before Pri2 and Pri3 📌 seQUESTered Identifies that an issue has been imported into Quest. 📦 release-9.0 Used to track doc updates for release 9.0 of .NET Aspire.
Milestone

Comments

@v-reinawang
Copy link

v-reinawang commented Nov 7, 2024

Describe the issue or suggestion

Issue description:
In "Tutorial: Deploy a .NET Aspire project with a SQL Server Database to Azure" doc, we need to make some updates to the instructions.

Issue1: [This problem exists in multiple documents]
The code in the document does not contain "WaitFor()".
Image

Expected:
The created Aspire Starter project contains the code "WaitFor()" by default.
Image

Issue2:
The code provided by the document[Configure the AppHost project] is obsolete.

Image

Expected: We can use AddAzureSqlServer instead of PublishAsAzureSqlDatabase
Image

Issue3: [This problem exists in multiple documents]
The azd up part of the documentation needs to be updated.
Image

Expected:
There is no SUCCESS information, and the Aspire Dashboard link is added.
Image


Associated WorkItem - 341259

@dotnetrepoman dotnetrepoman bot added the ⌚ Not Triaged Not triaged label Nov 7, 2024
@v-reinawang v-reinawang changed the title [WebToolsE2E][Aspire][Document] Some instructions need to be updated in "Tutorial: Deploy a .NET Aspire project with a SQL Server Database to Azure" [WebToolsE2E][Multiple docs] Some instructions need to be updated in "Tutorial: Deploy a .NET Aspire project with a SQL Server Database to Azure" Nov 8, 2024
IEvangelist added a commit that referenced this issue Nov 8, 2024
@IEvangelist IEvangelist self-assigned this Nov 8, 2024
@IEvangelist IEvangelist added 🗺️ reQUEST Triggers an issue to be imported into Quest. Pri1 High priority, do before Pri2 and Pri3 deployment Content related to deployment. doc-bug Problem with the content; needs to be fixed [org][type][category] okr-quality Content-health KR: Concerns article defects/freshness or build warnings. 📦 release-9.0 Used to track doc updates for release 9.0 of .NET Aspire. labels Nov 8, 2024
@IEvangelist IEvangelist added this to the 9.0 milestone Nov 8, 2024
@sequestor sequestor bot added 📌 seQUESTered Identifies that an issue has been imported into Quest. and removed 🗺️ reQUEST Triggers an issue to be imported into Quest. labels Nov 9, 2024
IEvangelist added a commit that referenced this issue Nov 11, 2024
@dotnetrepoman dotnetrepoman bot removed the ⌚ Not Triaged Not triaged label Nov 12, 2024
@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in dotnet/docs November 2024 sprint Nov 12, 2024
@v-reinawang
Copy link
Author

Verify that the issue has been fixed in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment Content related to deployment. doc-bug Problem with the content; needs to be fixed [org][type][category] in-pr okr-health okr-quality Content-health KR: Concerns article defects/freshness or build warnings. Pri1 High priority, do before Pri2 and Pri3 📌 seQUESTered Identifies that an issue has been imported into Quest. 📦 release-9.0 Used to track doc updates for release 9.0 of .NET Aspire.
Projects
No open projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants