Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android-projects.md: New linker settings #2211

Merged
merged 4 commits into from
Jun 19, 2024
Merged

Conversation

breyed
Copy link
Contributor

@breyed breyed commented Apr 25, 2024

Document new options and defaults for TrimMode. I took my best guess at the new content, but couldn’t find defninitive documentation. FWIW, here’s an AI-generated overview of the changes.


Internal previews

📄 File 🔗 Preview link
docs/migration/android-projects.md Xamarin.Android project migration

Document new options and defaults for `TrimMode`. I took my best guess at the new content, but couldn’t find defninitive documentation. FWIW, here’s an AI-generated [overview of the changes](https://g.co/gemini/share/c84935d1940b).
@davidbritch
Copy link
Contributor

@breyed This is the .NET 9 stuff?

@breyed
Copy link
Contributor Author

breyed commented May 16, 2024

According to dotnet/linker#3039, TrimMode=full and TrimMode=partial were introduced in .NET 7.

@jonathanpeppers
Copy link
Member

jonathanpeppers commented May 16, 2024

I wouldn't use TrimMode=full (on mobile) unless you are on .NET 9:

We plan to have more information about using this in a future preview.

@davidbritch
Copy link
Contributor

Hi @breyed

Thanks for the PR, and apologies for the delay in dealing with it. I've made some updates to it so that TrimMode=Full isn't mentioned (which is only available on mobile in .NET 9, and is still work-in-progress). We'll have more to say about TrimMode=Full once it's finalised.

Copy link
Contributor

@davidbritch davidbritch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @breyed

@davidbritch davidbritch merged commit 6330a64 into dotnet:main Jun 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants