Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xcsync docs #2593

Merged
merged 11 commits into from
Nov 11, 2024
Merged

Update xcsync docs #2593

merged 11 commits into from
Nov 11, 2024

Conversation

haritha-mohan
Copy link
Member

xcsync is now a open-source dotnet tool, so the docs needed a refresh. This follows the format precedent set by commands like dotnet watch: https://learn.microsoft.com/en-us/dotnet/core/tools/dotnet-tool-install

xcsync will also be included in the next pre-release version of the MAUI extension- should that be mentioned here? Or does anyone know where the extension specific docs belong?

Copy link
Member

@dalexsoto dalexsoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 🥳

Copy link
Contributor

@mcumming mcumming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

docs/macios/xcsync.md Show resolved Hide resolved
docs/macios/xcsync.md Outdated Show resolved Hide resolved
Copy link
Contributor

@mcumming mcumming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments

docs/macios/xcsync.md Show resolved Hide resolved
docs/macios/xcsync.md Show resolved Hide resolved
docs/macios/xcsync.md Outdated Show resolved Hide resolved
docs/macios/xcsync.md Show resolved Hide resolved
docs/macios/xcsync.md Outdated Show resolved Hide resolved
docs/macios/xcsync.md Outdated Show resolved Hide resolved
haritha-mohan and others added 2 commits November 1, 2024 10:35
Co-authored-by: Michael Cummings (MSFT) <mcumming@microsoft.com>
docs/macios/xcsync.md Outdated Show resolved Hide resolved
Co-authored-by: Michael Cummings (MSFT) <mcumming@microsoft.com>

Invoke the tool for a specific framework. The framework must be defined in the project file. Examples: `net9.0-ios`, `net9.0-maccatalyst`. **Required** if the .NET project supports multiple target frameworks (for example, a standard MAUI project). If a single platform project, the default value will be the single target framework specified in the project file.
- **`-t|--target <TARGET_XCODE_DIRECTORY>`**

The directory in which to place the generated Xcode project. Default value is `./obj/xcode`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this default value still correct? Or is it now $(IntermediateOutputPath)_/xcsync

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for catching that, yes that should be updated as well!

@davidbritch davidbritch merged commit 8239128 into dotnet:main Nov 11, 2024
4 checks passed
@haritha-mohan haritha-mohan deleted the update-xcsync-docs branch November 11, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants