-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update xcsync docs #2593
Update xcsync docs #2593
Conversation
9e3c120
to
6bf34cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!! 🥳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more comments
Co-authored-by: Michael Cummings (MSFT) <mcumming@microsoft.com>
Co-authored-by: Michael Cummings (MSFT) <mcumming@microsoft.com>
docs/macios/xcsync.md
Outdated
|
||
Invoke the tool for a specific framework. The framework must be defined in the project file. Examples: `net9.0-ios`, `net9.0-maccatalyst`. **Required** if the .NET project supports multiple target frameworks (for example, a standard MAUI project). If a single platform project, the default value will be the single target framework specified in the project file. | ||
- **`-t|--target <TARGET_XCODE_DIRECTORY>`** | ||
|
||
The directory in which to place the generated Xcode project. Default value is `./obj/xcode`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this default value still correct? Or is it now $(IntermediateOutputPath)_/xcsync
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for catching that, yes that should be updated as well!
xcsync is now a open-source dotnet tool, so the docs needed a refresh. This follows the format precedent set by commands like dotnet watch: https://learn.microsoft.com/en-us/dotnet/core/tools/dotnet-tool-install
xcsync will also be included in the next pre-release version of the MAUI extension- should that be mentioned here? Or does anyone know where the extension specific docs belong?