Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix null forgiving F1 keyword #20341

Merged
merged 1 commit into from
Sep 8, 2020
Merged

Fix null forgiving F1 keyword #20341

merged 1 commit into from
Sep 8, 2020

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Aug 28, 2020 •
edited
Loading

@dotnet-bot dotnet-bot added this to the August 2020 milestone Aug 28, 2020
@BillWagner BillWagner modified the milestones: August 2020, September 2020 Sep 1, 2020
@Youssef1313 Youssef1313 mentioned this pull request Sep 7, 2020
Merged
@Youssef1313 Youssef1313 marked this pull request as ready for review September 7, 2020 21:20
@Youssef1313
Copy link
Member Author

@BillWagner Once dotnet/roslyn#47516 is reviewed for correctness, this should be ready to merge, then Roslyn's PR.

davidwengier
davidwengier approved these changes Sep 7, 2020
View reviewed changes
Copy link
Contributor

@davidwengier davidwengier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there is any reason to wait for the Roslyn PR to be approved, having the same f1_keyword in two pages is a problem regardless of whether any code currently points to it.

davidwengier
davidwengier approved these changes Sep 7, 2020
View reviewed changes
Copy link
Contributor

@davidwengier davidwengier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there is any reason to wait for the Roslyn PR to be approved, having the same f1_keyword in two pages is a problem regardless of whether any code currently points to it.

@IEvangelist IEvangelist merged commit 12b946b into dotnet:master Sep 8, 2020
@Youssef1313 Youssef1313 deleted the patch-17 branch October 6, 2020 00:45
@Youssef1313 Youssef1313 mentioned this pull request Oct 6, 2020
Open
17 tasks
@davidwengier davidwengier mentioned this pull request Oct 7, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwengier davidwengier davidwengier approved these changes

@BillWagner BillWagner Awaiting requested review from BillWagner

Assignees
No one assigned
Labels
dotnet-csharp/svc lang-reference/subsvc
Projects
None yet
Milestone
September 2020
Development

Successfully merging this pull request may close these issues.

Issue with !_CSharpKeyword
5 participants
@Youssef1313 @davidwengier @BillWagner @IEvangelist @dotnet-bot