Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nullability annotations breaking change #22798

Merged
merged 2 commits into from
Feb 12, 2021
Merged

Nullability annotations breaking change #22798

merged 2 commits into from
Feb 12, 2021

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Feb 11, 2021 •
edited
Loading

Contributes to #21202.

Internal preview link.

@dotnet-bot dotnet-bot added this to the February 2021 milestone Feb 11, 2021
luisquintanilla
luisquintanilla approved these changes Feb 12, 2021
View reviewed changes
Copy link
Contributor

@luisquintanilla luisquintanilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jeffhandley
jeffhandley approved these changes Feb 12, 2021
View reviewed changes
Copy link
Member

@jeffhandley jeffhandley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gewarren gewarren merged commit a10546c into dotnet:master Feb 12, 2021
@gewarren gewarren deleted the null-annotations branch February 12, 2021 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luisquintanilla luisquintanilla luisquintanilla approved these changes

@jeffhandley jeffhandley jeffhandley approved these changes

Assignees
No one assigned
Labels
dotnet-fundamentals/svc
Projects
None yet
Milestone
February 2021
Development

Successfully merging this pull request may close these issues.
4 participants
@gewarren @jeffhandley @luisquintanilla @dotnet-bot