initial docs on async method builders #24973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add and update the description of AsyncMethodBuilder, and the new feature that it can be applied to a method.
tdykstra
approved these changes
Jul 6, 2021
| @@ -19,33 +19,33 @@ If the `TRACE_ON` identifier isn't defined, the trace output isn't displayed. Ex | |||
|
|
|||
| The `Conditional` attribute is often used with the `DEBUG` identifier to enable trace and logging features for debug builds but not in release builds, as shown in the following example: | |||
|
|
|||
| :::code language="csharp" source="snippets/ConditionalExamples.cs" id="SnippetConditional" ::: | |||
There was a problem hiding this comment.
What's the motivation for changing id to ID? Our guidance in the contributor guide uses lowercase.
There was a problem hiding this comment.
@tdykstra Acrolinx marks down "id" in favor of "ID". Enough samples, and it has a measurable effect on the score.
Should I ping @MonicaRush on that one? (I'd honestly thought the guidance had changed when it kept getting flagged)
There was a problem hiding this comment.
Yes, this should count as a false positive, Acrolinx shouldn't be applying general text rules to triple-colon statements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add and update the description of AsyncMethodBuilder, and the new feature that it can be applied to a method.
Fixes #24950
See issue #24972 to track the remaining task.
Notes on changes are on the issue: #24950 (comment)