Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System.Text.Json - source generation updates #26502

Merged
merged 4 commits into from
Oct 15, 2021
Merged

System.Text.Json - source generation updates #26502

merged 4 commits into from
Oct 15, 2021

Conversation

tdykstra
Copy link
Contributor

@tdykstra tdykstra commented Oct 13, 2021 •
edited
Loading

Fixes #25451 (review)

File Type File Name Published Url
Content docs/standard/serialization/system-text-json-source-generation.md https://review.docs.microsoft.com/en-us/dotnet/standard/serialization/system-text-json-source-generation?branch=pr-en-us-26502

@dotnet-bot dotnet-bot added this to the October 2021 milestone Oct 13, 2021
@tdykstra tdykstra requested review from layomia, adegeo and a team October 13, 2021 21:18
@tdykstra tdykstra closed this Oct 13, 2021
@tdykstra tdykstra reopened this Oct 13, 2021
gewarren
gewarren approved these changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tdykstra tdykstra merged commit 5074fda into dotnet:main Oct 15, 2021
@tdykstra tdykstra deleted the 25451followup branch October 15, 2021 23:34
@tdykstra
Copy link
Contributor Author

@gewarren Thanks for the review!

@tdykstra tdykstra added the okr-freshness OKR: Freshness of content label Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gewarren gewarren gewarren approved these changes

@layomia layomia Awaiting requested review from layomia

@adegeo adegeo Awaiting requested review from adegeo

Assignees
No one assigned
Labels
dotnet-fundamentals/svc okr-freshness OKR: Freshness of content
Projects
None yet
Milestone
October 2021
Development

Successfully merging this pull request may close these issues.
3 participants
@tdykstra @gewarren @dotnet-bot