Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Caller argument expression #26782

Merged
merged 7 commits into from
Nov 3, 2021
Merged

Caller argument expression #26782

merged 7 commits into from
Nov 3, 2021

Conversation

BillWagner
Copy link
Member

Fixes #25680

This adds a description of the CallerArgumentExpression in the language reference.

@BillWagner
First draft
a9535d6
@BillWagner
Proofread
99afbc2 
Also notice that the index doesn't show C# 10, but shows the C# 9.0 release as latest.
@dotnet-bot dotnet-bot added this to the November 2021 milestone Nov 2, 2021
@BillWagner BillWagner added the okr-freshness OKR: Freshness of content label Nov 2, 2021
KathleenDollard
KathleenDollard reviewed Nov 2, 2021
View reviewed changes
Copy link
Contributor

@KathleenDollard KathleenDollard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than one mistake in an exception name. I also had opinions.

docs/csharp/language-reference/attributes/caller-information.md Outdated Show resolved Hide resolved
docs/csharp/language-reference/attributes/caller-information.md Show resolved Hide resolved
docs/csharp/whats-new/csharp-10.md Outdated Show resolved Hide resolved
docs/csharp/whats-new/csharp-10.md
}
```

You can learn more about this feature in the article on [Caller information attributes](../language-reference/attributes/caller-information.md#argument-expressions) in the language reference section.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is hte article I flagged in an issue as needing review. Or maybe I didn't save that as you said you were working on this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's dotnet/dotnet-api-docs#26784

If I'm correct, this will get updated when we update to RC2. @gewarren can confirm.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BillWagner I think you meant #26784. Can you confirm that the attribute is implemented in the compiler now? If so, we'll need to manually remove the note block.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I did. Thanks @gewarren

Yes, this is implemented in the compiler now, as of the current public RC for .NET 6.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated here: https://github.com/dotnet/dotnet-api-docs/pull/7351/files

docs/visual-basic/programming-guide/concepts/caller-information.md Outdated Show resolved Hide resolved
gewarren
gewarren reviewed Nov 2, 2021
View reviewed changes
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some suggestions for consideration.

docs/csharp/language-reference/attributes/caller-information.md Outdated Show resolved Hide resolved
docs/csharp/language-reference/attributes/caller-information.md Outdated Show resolved Hide resolved
docs/csharp/language-reference/attributes/caller-information.md Outdated Show resolved Hide resolved
docs/csharp/whats-new/csharp-10.md Show resolved Hide resolved
docs/visual-basic/programming-guide/concepts/caller-information.md Outdated Show resolved Hide resolved
BillWagner and others added 3 commits November 3, 2021 07:22
@BillWagner @gewarren @KathleenDollard
Apply suggestions from code review
af11ac5 
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Co-authored-by: Kathleen Dollard <kathleen.dollard@microsoft.com>
@BillWagner
respond to comments.
f2b68d4
@BillWagner
build warning.
f796152
@BillWagner BillWagner merged commit 82ce6fa into dotnet:main Nov 3, 2021
@BillWagner BillWagner deleted the caller-argument-expression branch November 3, 2021 13:18
@cremor
Copy link

cremor commented Nov 4, 2021

@BillWagner On the top of the "What's new in C# 10.0" page there is a list of items. It looks like a table of contents but isn't. You didn't add a link to your new chapter there, was this on purpose?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gewarren gewarren gewarren left review comments

@KathleenDollard KathleenDollard KathleenDollard left review comments

@333fred 333fred 333fred approved these changes

Assignees
No one assigned
Labels
dotnet-csharp/svc dotnet-visualbasic/svc lang-reference/subsvc okr-freshness OKR: Freshness of content whats-new/subsvc
Projects
None yet
Milestone
November 2021
Development

Successfully merging this pull request may close these issues.

Caller argument expression
6 participants
@BillWagner @cremor @333fred @KathleenDollard @gewarren @dotnet-bot