Document some internal SQL type ctors as additional-apis #28911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gewarren
reviewed
Apr 5, 2022
docs/framework/additional-apis/system.data.sqltypes.sqlbinary.-ctor.md
Outdated
Show resolved
Hide resolved
docs/framework/additional-apis/system.data.sqltypes.sqlbinary.-ctor.md
Outdated
Show resolved
Hide resolved
docs/framework/additional-apis/system.data.sqltypes.sqlguid.-ctor.md
Outdated
Show resolved
Hide resolved
docs/framework/additional-apis/system.data.sqltypes.sqlguid.-ctor.md
Outdated
Show resolved
Hide resolved
docs/framework/additional-apis/system.data.sqltypes.sqlmoney.-ctor.md
Outdated
Show resolved
Hide resolved
docs/framework/additional-apis/system.data.sqltypes.sqlmoney.-ctor.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
|
@gewarren Had a little bit of trouble finding the TOC file, but I think I got it now. :) |
|
Note: I used "structure" instead of "class" to match precedent already in the additional-apis section of the TOC. - name: stdole namespace
items:
- name: DISPPARAMS structure
href: additional-apis/stdole.dispparams.md
- name: EXCEPINFO structure
href: additional-apis/stdole.excepinfo.md |
Sorry, I should have pointed you to it. It can be tricky to find. |
gewarren
approved these changes
Apr 5, 2022
|
/cc @dotnet/sqlclientdevteam Please let me know if you have any feedback on these docs before merge. |
This was referenced Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Documents internal ctors for three SQL-related types:
SqlGuid,SqlBinary, andSqlDecimal. The out-of-band package Microsoft.Data.SqlClient currently uses unsupported union overlays to access these types (see dotnet/runtime#51836). We can update the code to use a less fragile private reflection pattern, but it first requires properly documenting these APIs under the additional-apis subfolder.