Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation-notice to rule CA2109 #31797

Merged
merged 3 commits into from
Nov 9, 2022
Merged

Add deprecation-notice to rule CA2109 #31797

merged 3 commits into from
Nov 9, 2022

Conversation

x789
Copy link
Contributor

@x789 x789 commented Oct 16, 2022

Adds a deprecation notice to rule CA2109 (similar to #21882)

Rule is removed by PR dotnet/roslyn-analyzers#6198.
Removal of the rule was discussed in dotnet/roslyn-analyzers#5974.

@x789 x789 requested a review from gewarren as a code owner October 16, 2022 11:43
@dotnet-bot dotnet-bot added this to the October 2022 milestone Oct 16, 2022
@ghost ghost added the community-contribution Indicates PR is created by someone from the .NET community. label Oct 16, 2022
@x789 x789 mentioned this pull request Oct 16, 2022
@x789 x789 changed the title Add deprecation notice to rule CA2109 Add deprecation-notice to rule CA2109 Oct 16, 2022
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @x789

docs/fundamentals/code-analysis/quality-rules/ca2109.md Outdated Show resolved Hide resolved
docs/fundamentals/code-analysis/quality-rules/ca2109.md Outdated Show resolved Hide resolved
@gewarren gewarren added the 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) label Oct 17, 2022
x789 and others added 2 commits October 17, 2022 19:37
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@BillWagner BillWagner enabled auto-merge (squash) November 9, 2022 16:00
@BillWagner BillWagner merged commit a978c0f into dotnet:main Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates PR is created by someone from the .NET community. 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) dotnet-fundamentals/svc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants