Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Console encoding breaking change #34365

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Console encoding breaking change #34365

merged 1 commit into from
Mar 6, 2023

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Mar 4, 2023 •
edited
Loading

Fixes #34250

Preview

@dotnet-bot dotnet-bot added this to the March 2023 milestone Mar 4, 2023
@ghost ghost added the 🏁 Release: .NET 8 Work items for the .NET 8 release label Mar 4, 2023
@gewarren gewarren requested review from nagilson and a team March 4, 2023 01:16
IEvangelist
IEvangelist approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, :shipit: when you're ready.

@nagilson
Copy link
Member

nagilson commented Mar 6, 2023

LGTM :)

@gewarren gewarren merged commit d66daca into dotnet:main Mar 6, 2023
@gewarren gewarren deleted the cli-encoding branch March 6, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IEvangelist IEvangelist IEvangelist approved these changes

@nagilson nagilson nagilson approved these changes

Assignees
No one assigned
Labels
🏁 Release: .NET 8 Work items for the .NET 8 release dotnet-fundamentals/svc
Projects
None yet
Milestone
March 2023
Development

Successfully merging this pull request may close these issues.

[Breaking change]: .NET 8 Uses UTF 8 Encoding in Non-EN Languages
4 participants
@gewarren @nagilson @IEvangelist @dotnet-bot