Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add guidelines for packaging source-built NativeAOT. #41623

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Add guidelines for packaging source-built NativeAOT. #41623

merged 2 commits into from
Jul 9, 2024

Conversation

tmds
Copy link
Member

@tmds tmds commented Jul 2, 2024 •
edited by github-actions bot
Loading

@tmds tmds requested a review from a team as a code owner July 2, 2024 09:18
@dotnet-bot dotnet-bot added this to the July 2024 milestone Jul 2, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates PR is created by someone from the .NET community. label Jul 2, 2024
@omajid
Copy link
Member

omajid commented Jul 3, 2024

Thanks for documenting this, @tmds !

I implemented this for our WIP .NET 9 packages and it seems to work well.

The generated dotnet-sdk-aot-9.0 package has a size of around 60 MB. dotnet/library-packs/ has a size of around 740 KB.

@tmds
Copy link
Member Author

tmds commented Jul 4, 2024

The generated dotnet-sdk-aot-9.0 package has a size of around 60 MB.

I'll be looking into reducing its size after my summer break.

gewarren
gewarren approved these changes Jul 8, 2024
View reviewed changes
docs/core/distribution-packaging.md Outdated Show resolved Hide resolved
docs/core/distribution-packaging.md Outdated Show resolved Hide resolved
@tmds @gewarren
Apply suggestions from code review
ec75da6 
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@gewarren gewarren merged commit b052592 into dotnet:main Jul 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gewarren gewarren gewarren approved these changes

@omajid omajid omajid approved these changes

Assignees
No one assigned
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-fundamentals/svc
Projects
None yet
Milestone
July 2024
Development

Successfully merging this pull request may close these issues.
4 participants
@tmds @omajid @gewarren @dotnet-bot