Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Resilient HTTP apps] Add a paragraph describing how to disable retries for some HTTP methods #43630

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

iliar-turdushev
Copy link
Contributor

@iliar-turdushev iliar-turdushev commented Nov 18, 2024

The PR adds description how to disable retries for some HTTP methods.

Fixes #5248


Internal previews

📄 File 🔗 Preview link
docs/core/resilience/http-resilience.md Build resilient HTTP apps: Key development patterns

Adds description how to disable retries for some HTTP methods
@iliar-turdushev
Copy link
Contributor Author

The API described in the PR will be released in dotnet/extensions 9.1.0 (https://github.com/dotnet/extensions). We want to merge the PR only after that release.

@eduherminio eduherminio self-requested a review November 19, 2024 11:25
Copy link

@dariusclay dariusclay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions but will leave it up to @IEvangelist to confirm

docs/core/resilience/http-resilience.md Outdated Show resolved Hide resolved
docs/core/resilience/http-resilience.md Outdated Show resolved Hide resolved
docs/core/resilience/http-resilience.md Outdated Show resolved Hide resolved
Co-authored-by: Darius Letterman <dcletterman@gmail.com>
@IEvangelist IEvangelist added blocked Blocked for some reason DO NOT MERGE labels Nov 20, 2024
@IEvangelist
Copy link
Member

Added the DO NOT MERGE label, while this is approved and looks good, we're currently blocked as the corresponding NuGet package version isn't available yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Two Mistakes in the Documentation
6 participants