update .net standard topic #6556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpetrusha
approved these changes
Jul 19, 2018
docs/standard/net-standard.md
Outdated
|
|
||
| ## .NET Framework compatibility mode | ||
|
|
||
| Starting with .NET Standard 2.0, the .NET Framework compatibility mode was introduced. This compatibility mode allows .NET Standard projects to reference .NET Framework libraries as if they were compiled for .NET Standard. Referencing .NET Framework libraries doesn't work for all projects, such as if the library uses Windows Presentation Foundation (WPF) APIs. |
There was a problem hiding this comment.
nit: such as if the library uses --> such as libraries that use
docs/standard/net-standard.md
Outdated
|
|
||
| NuGet packages target one or more [frameworks](frameworks.md). The .NET Standard packages target the ".NET Standard" framework. You can target the .NET Standard Framework using the `netstandard` [compact TFM](frameworks.md) (for example, `netstandard1.4`). Libraries that are intended to run on multiple runtimes should target this framework. | ||
| NuGet packages target one or more [frameworks](frameworks.md). The .NET Standard packages target the ".NET Standard" framework. You can target the .NET Standard Framework using the `netstandard` [compact TFM](frameworks.md) (for example, `netstandard1.4`). Libraries that are intended to run on multiple runtimes should target this framework. If you want a broader set of APIs, you should target `netstandard2.0` since the number of available APIs more than doubled between .NET Standard 1.6 and 2.0. |
There was a problem hiding this comment.
- nit: should framework in .NET Standard Framework be capitalized (I suspect not)
- The "if you want" sentence seems out of place. I think a slight rewrite helps: "You can target the .NET Standard framework using the `netstandard` [compact target framework moniker](link) (TFM). Libraries that are intended to run on multiple platforms should target at least `netstandard1.4`. For the broadest set of APIs, target...
docs/standard/net-standard.md
Outdated
|
|
||
| ## .NET Standard libraries and Visual Studio | ||
|
|
||
| In order to build .NET Standard libraries in Visual Studio, make sure you have [Visual Studio 2017 version 15.3](https://visualstudio.microsoft.com/downloads/?utm_medium=microsoft&utm_source=docs.microsoft.com&utm_campaign=button+cta&utm_content=download+vs2017) or later installed on Windows or [Visual Studio for Mac version 7.1](https://visualstudio.microsoft.com/vs/visual-studio-mac/) or later installed on macOS. |
docs/standard/net-standard.md
Outdated
|
|
||
| Similarities: | ||
|
|
||
| - Defines APIs that can be used for binary code sharing. |
There was a problem hiding this comment.
Defines --> Define (they is the implicit subject)
docs/standard/net-standard.md
Outdated
|
|
||
| - .NET Standard is a curated set of APIs, while PCL profiles are defined by intersections of existing platforms. | ||
| - .NET Standard linearly versions, while PCL profiles do not. | ||
| - PCL profiles represents Microsoft platforms while the .NET Standard is agnostic to platform. |
There was a problem hiding this comment.
agnostic to platform --> platform-agnostic
|
Thank you @rpetrusha for your feedback. Comments addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2927
@terrajobst @davidfowl can you please take a look and see if there's anything else that should be updated?
I've moved all the PCL info to the bottom.
Internal review URL