Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SqlBulkCopy.RowsCopied property to docs #4916

Closed

Conversation

stylesm
Copy link

@stylesm stylesm commented Sep 30, 2020

Added the RowsCopied property to docs for SqlBulkCopy, which was added in System.Data.SqlClient 2.0.0.

See dotnet/SqlClient#409.

@dnfadmin
Copy link

dnfadmin commented Sep 30, 2020

CLA assistant check
All CLA requirements met.

@opbld32
Copy link

opbld32 commented Sep 30, 2020

Docs Build status updates of commit 4b391b2:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
xml/System.Data.SqlClient/SqlBulkCopy.xml ❌Error Details

xml/System.Data.SqlClient/SqlBulkCopy.xml

  • Line 0, Column 0: [Error-ECMA2Yaml_Framework_NotFound] Unable to find framework info for P:System.Data.SqlClient.SqlBulkCopy.RowsCopied

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@carlossanlop
Copy link
Member

Thanks for your contribution, @stylesm, but we are not supposed to add full xml elements manually. We have tooling that detects new APIs from the latest ref assemblies, and then the Docs build system generates the xmls automatically based on that information.

@safern does your batch of ref assemblies include the SqlClient ones?

@safern
Copy link
Member

safern commented Oct 1, 2020

@safern does your batch of ref assemblies include the SqlClient ones?

No I currently don't include SqlClient. We would need to add it to our drop items in our api-docs infra repo. I guess we would add it as part of extensions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants