Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add step about CODEOWNERS in README #1161

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Add step about CODEOWNERS in README #1161

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7231297
Add step about CODEOWNERS in README
ellahathaway Aug 7, 2024
03cdf43
PR feedback
ellahathaway Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@ There will be a need for modifying existing Dockerfiles or creating new ones. F

1. Edit Dockerfiles
- Add/Update the Dockerfile(s)
- If new Dockerfile(s) were added, then update the [manifest](#manifest)
- If new Dockerfile(s) were added:
- Update the [manifest](#manifest)
- Update the [CODEOWNERS](./CODEOWNERS) with the respective team code owner(s) (not individual users) for the Dockerfile(s). A team code owner must be assigned to each Dockerfile for maintenance and issue assignment purposes.

2. Validate the changes locally by running [build.ps1](./build.ps1). It is strongly suggested to specify the `-DockerfilePath` option to avoid the overhead of building all the images.

Expand Down