Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make @dotnet/dotnet-docker-reviewers an owner of every file #1164

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

ellahathaway
Copy link
Member

Closes #1163

This PR introduces changes to add @dotnet/dotnet-docker-reviewers as a code owner for every file in the repo. These changes include the addition of a validation step to require that the team is included as an owner on all entries in the CODEOWNERS file.

This PR also moves the assignment of general paths such as helix to the bottom of the CODEOWNERS file so that the owners don't get overridden by entries for specific groups of Dockerfiles (such as alpine Dockerfile assignments).

CODEOWNERS Outdated Show resolved Hide resolved
@ellahathaway ellahathaway requested a review from mthalman August 8, 2024 16:02
@ellahathaway ellahathaway enabled auto-merge (squash) August 8, 2024 16:24
@ellahathaway ellahathaway merged commit a10cfbc into dotnet:main Aug 8, 2024
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CODEOWNERS file doesn't include docker review team by default
2 participants